← Back to issue list

(internal) Moved get_instance_name functionality to providers helper (CRAFT-1304).

View original Github issue

Metadata

Project
charmcraft
Number
#885
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged the CRAFT-1304 refactor in #885, moving get_instance_name functionality to the providers helper.

Resolution: closed resolved

Reason: PR #885 was approved and merged as commit c87371ef, completing the internal provider-helper refactor.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged the CRAFT-1304 refactor in #885, moving get_instance_name functionality to the providers helper.
stealth/space-bunny-alpha — closed resolved Merged internal refactor moving get_instance_name into a providers helper (CRAFT-1304), changing 8 files (+72/-121).
qwen/qwen3.6-35b-a3b — — Merged refactoring moving get_instance_name to a providers helper, resolving CRAFT-1304. Approved by one reviewer with no unresolved comments, spanning eight files with a net reduction of 49 lines.
qwen3.6-35b-a3b-mtp-q6 — — The get_instance_name functionality was moved to the providers helper, resolving internal ticket CRAFT-1304. The pull request was merged and integrated without additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#74 providers: move get_instance_name() to providers.py rockcraft merged Merged in canonical/rockcraft#74 (c5423c5a), moving Rockcraft-specific get_instance_name() into providers.py for CRAFT-1350.
78%
#3926 providers: move `get_instance_name()` to providers.py snapcraft merged Merged as commit c1246cbe3 (+82/-45, 6 files): moved the snapcraft-specific get_instance_name() out of craft-providers into snapcraft/providers/providers.py (CRAFT-1305 prep for the new craft-providers API).
77%
#407 providers: add get_instance_name() for naming instances (CRAFT-310) charmcraft merged Merged PR #407 added providers.get_instance_name() for launch instance naming in CRAFT-310 (commit 0cb02bf4; merge d9179bdf).
74%
#80 providers: move `get_instance_name()` call to lifecycle.py rockcraft merged Merged canonical/rockcraft#80 as ca679971, moving Rockcraft-specific get_instance_name() from Provider classes to lifecycle.py (CRAFT-1379).
72%