(internal) Moved get_instance_name functionality to providers helper (CRAFT-1304).
Metadata
Current evaluation
Merged refactoring moving get_instance_name to a providers helper, resolving CRAFT-1304. Approved by one reviewer with no unresolved comments, spanning eight files with a net reduction of 49 lines.
Suggested action: —
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring moving get_instance_name to a providers helper, resolving CRAFT-1304. Approved by one reviewer with no unresolved comments, spanning eight files with a net reduction of 49 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | The get_instance_name functionality was moved to the providers helper, resolving internal ticket CRAFT-1304. The pull request was merged and integrated without additional discussion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged PR by facundobatista moving get_instance_name functionality to the providers helper, addressing CRAFT-1304. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #74 providers: move get_instance_name() to providers.py | rockcraft | merged | Merged after approval and passing CI. Moved the rockcraft-specific get_instance_name() function to providers.py, changing 8 files. Resolves CRAFT-1350. | |
| #3926 providers: move `get_instance_name()` to providers.py | snapcraft | merged | Merged. Moved get_instance_name() to snapcraft/providers/providers.py, removing snapcraft-specific logic from provider modules. This refactoring prepares the codebase for the new craft-providers API. Approved by reviewers and passed all CI checks. | |
| #407 providers: add get_instance_name() for naming instances (CRAFT-310) | charmcraft | merged | Merged addition of get_instance_name() for instance naming (CRAFT-310). Approved by two reviewers with zero unresolved comments. Introduces 54 lines across two files and was signed off by maintainer Chris Patterson. | |
| #92 providers: refactor get_provider() | rockcraft | merged | Merged after approval and passing CI. Refactored and moved get_provider() from _get_provider.py to providers.py across seven files, reducing code by 25 lines. Resolves CRAFT-1375. | |
| #80 providers: move `get_instance_name()` call to lifecycle.py | rockcraft | merged | Merged. Moved the rockcraft-specific get_instance_name() call from provider classes to lifecycle.py to separate application-specific logic. Approved by reviewer, CI passed, spanning 6 files with 57 additions and 34 deletions. | |
| #886 (internal) Moved the mount of instance directory outside of providers. | charmcraft | merged | Merged an internal refactoring that moved instance directory mounting outside of providers. Approved by one reviewer, the change modified 8 files with 30 additions and 26 deletions. |