fix: use craft-application clean command
Metadata
Current evaluation
PR #1420 (switch clean to craft-application) was closed unmerged, with no matching commit in charmcraft/commands/clean.py history. The same cleanup landed later via merged PR #1571 (commit 053d5a2d), which deleted the redundant clean command.
Resolution: closed superseded
Reason: PR #1420 was closed without merging; git log for charmcraft/commands/clean.py contains no commit for it, while its dependency #1419 did merge (c3ae865e). The intended removal of Charmcraft's redundant clean command was completed later by merged PR #1571 (commit 053d5a2d).
Evaluated by: mr-cal-bot
No scores available.
Issue body
Requires #1419
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #1420 (switch clean to craft-application) was closed unmerged, with no matching commit in charmcraft/commands/clean.py history. The same cleanup landed later via merged PR #1571 (commit 053d5a2d), which deleted the redundant clean command. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; the craft-application clean-command cleanup was completed later by merged PR #1571 (commit 053d5a2d). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; the obsolete clean implementation was later removed in canonical/charmcraft#1571 (053d5a2d) because craft-application already provided clean. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed pull request implementing a fix to use the craft-application clean command. The change modifies five files, removing 300 lines and adding 10. No review comments or CI checks were recorded. The PR was closed without explicit merge status. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed and abandoned pending PR #1419. No merge activity or comments were recorded. The update to use the craft-application clean command was not merged. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/charmcraft#1571
(confidence 95%)
Merged PR that removed the unused clean command implementation (commit 053d5a2d), fulfilling #1420's intent; file absent at HEAD.
-
Blocked By:
canonical/charmcraft#1419
(confidence 90%)
Stated prerequisite; merged as c3ae865e removing the non-craft-application analyze command.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| #412 clean: introduce clean command (CRAFT-62) | charmcraft | merged | Merged PR #412 (commit 23db6367, merge 646bc259) added a `clean` command removing Charmcraft-created LXD build containers, plus a caplog filter fixture. Later removed as unused in #1571. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs. | |
| #1338 `charmcraft clean` doesn't clean | charmcraft | closed | Closed unresolved: LXD cleanup remained broken in Charmcraft 3, with the changed behavior attributed to craft-application#425, which also closed without a linked fix. | |
| #1340 feat(craft-app): move init command | charmcraft | merged | PR #1340 by lengau merged, relocating charmcraft's init command into craft-application (with the init service/command/tests) plus lint fixes (+500/-343, 18 files). Later cleanup commit 97fa9229 (#1520) removed the old implementation. | |
| #2795 docs: improve `charmcraft clean` command documentation | charmcraft | closed | Closed unmerged; maintainer @lengau rejected the proposed charmcraft clean documentation as subpar, and no documentation commit or replacement PR landed. | |
| #1563 fix: breaking changes from craft-application main | charmcraft | merged | Merged charmcraft#1563 as commit 8dce5351, updating Charmcraft for breaking API changes on craft-application main. | |
| #1564 fix: remove distutils and use craft-application.util | charmcraft | merged | Merged PR #1564 (commit b4fcdcf3) replaced distutils with craft-application.util in three files, fixing Python 3.12 compatibility and resolving #1527. |