refactor: remove unused clean command implementation
Metadata
Current evaluation
Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling.
Resolution: closed resolved
Reason: PR #1571 was merged and resolved the cleanup by deleting the unused custom clean implementation and its tests. The resulting change is recorded in commit 053d5a2d.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Now that we're using the craft-application `clean` command we don't need to compare to the 2.x clean command.
This removes the regression tests and the old implementation
Remote build test is fixed in #1573
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1571 (commit 053d5a2d) by lengau deleted the legacy charmcraft clean command (charmcraft/commands/clean.py) and its regression tests, since clean now comes from craft-application. Remote-build smoke test fix followed in #1573. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #1571 merged as commit 053d5a2d, deleting Charmcraft's obsolete custom clean command implementation and its 2.x comparison regression tests now that clean comes from craft-application. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1571 (053d5a2d), removing Charmcraft's obsolete custom clean command and regression tests now that clean is provided by craft-application. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor removing the unused legacy clean command implementation and associated regression tests. The craft-application clean command now provides this functionality, with the related remote build test resolved in #1573. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1573
(confidence 99%)
Follow-up PR referenced by #1571 that fixed the remote-build smoke test.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1420 fix: use craft-application clean command | charmcraft | closed | PR #1420 (switch clean to craft-application) was closed unmerged, with no matching commit in charmcraft/commands/clean.py history. The same cleanup landed later via merged PR #1571 (commit 053d5a2d), which deleted the redundant clean command. | |
| #1572 refactor: remove unused extension command implementations | charmcraft | merged | Merged PR #1572 removed Charmcraft’s unused extension command implementations and moved their tests to craft-application; remote-build test fixes were handled separately in #1573. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged PR #1520 in commit 97fa9229, removing 248 lines of obsolete init command code after the craft-application transition. | |
| #412 clean: introduce clean command (CRAFT-62) | charmcraft | merged | Merged PR #412 (commit 23db6367, merge 646bc259) added a `clean` command removing Charmcraft-created LXD build containers, plus a caplog filter fixture. Later removed as unused in #1571. | |
| #1419 refactor: remove non craft-application analyze command | charmcraft | merged | Merged PR #1419 as c3ae865e, removing the accidentally retained non-craft-application analyze command while keeping the craft-application version. | |
| #1340 feat(craft-app): move init command | charmcraft | merged | PR #1340 by lengau merged, relocating charmcraft's init command into craft-application (with the init service/command/tests) plus lint fixes (+500/-343, 18 files). Later cleanup commit 97fa9229 (#1520) removed the old implementation. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs. | |
| #1663 refactor: remove unused fetch-lib command | charmcraft | merged | PR #1663 (commit b3d35e6d) merged, deleting the unused pre-craft-application fetch-lib implementation; the public fetch-lib command was kept and #1665 added fetch-libs for charmcraft.yaml-declared libraries. | |
| #1765 chore: remove classic entrypoint | charmcraft | merged | Merged charmcraft#1765 as commit ffca2b8e, removing the obsolete classic entrypoint left over from the craft-application migration. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues. |