refactor: remove unused clean command implementation
Metadata
Current evaluation
Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files.
Suggested action: —
No scores available.
Issue body
Now that we're using the craft-application `clean` command we don't need to compare to the 2.x clean command.
This removes the regression tests and the old implementation
Remote build test is fixed in #1573
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor removing the unused legacy clean command implementation and associated regression tests. The craft-application clean command now provides this functionality, with the related remote build test resolved in #1573. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor removing the unused legacy clean command implementation and its regression tests, as craft-application now handles the functionality. The associated remote build test was resolved separately in #1573. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. | |
| #1572 refactor: remove unused extension command implementations | charmcraft | merged | Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files. | |
| #4682 refactor(app): use more code from craft-app | snapcraft | merged | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| #1419 refactor: remove non craft-application analyze command | charmcraft | merged | Merged refactoring that removes a superfluous non-craft-application version of the analyze command. Approved by three reviewers with zero unresolved comments. Modified seven files, deleting 339 lines and adding 135. | |
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed. | |
| #1420 fix: use craft-application clean command | charmcraft | closed | Closed pull request implementing a fix to use the craft-application clean command. The change modifies five files, removing 300 lines and adding 10. No review comments or CI checks were recorded. The PR was closed without explicit merge status. | |
| #398 Remove now unused functionalities (CRAFT-241). | charmcraft | merged | Merged following approval by two reviewers. Removed unused functionalities referenced as CRAFT-241, altering two files with a net deletion of 229 lines. No unresolved review comments or CI checks were required. | |
| #5205 refactor: use craft-platforms utilities | snapcraft | merged | Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). | |
| #1591 tests: remove regression test for command help | charmcraft | merged | Merged removal of a regression test for command help, as the craft-application base is now stable. Approved by two reviewers, the change deletes 93 lines across one file. |