← Back to issue list

build: integrate craft-parts lifecycle (CRAFT-89, CRAFT-367, CRAFT-357)

View original Github issue

Metadata

Project
charmcraft
Number
#458
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #458 via 9dc20872 (implementation 437dab55), adding a craft-parts lifecycle and charm build plugin to run the charm builder.

Resolution: closed resolved

Reason: PR #458 was approved and merged as 9dc20872, with implementation in commit 437dab55. It introduced the lifecycle and plugin integration described in the pull request.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Create and run the craft-parts lifecycle, executing the charm builder from a craft-parts charm build plugin. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #458 via 9dc20872 (implementation 437dab55), adding a craft-parts lifecycle and charm build plugin to run the charm builder.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#458 via commit 9dc20872 (implementation 437dab55), integrating the craft-parts lifecycle and a charm plugin that runs the charm builder.
stealth/space-bunny-alpha — closed resolved Merged PR #458 via 9dc20872 (implementation 437dab55), integrating the craft-parts lifecycle and a charm build plugin to run the charm builder.
stealth/space-bunny-alpha — closed resolved PR #458 by cmatsuoka merged (9dc20872, impl 437dab55): charmcraft now creates and runs a craft-parts lifecycle, executing the charm builder from a craft-parts charm build plugin, resolving CRAFT-89/367/357.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#458 via 9dc20872, adding a craft-parts lifecycle and charm build plugin to run the charm builder; implementation: 437dab55.
qwen/qwen3.6-35b-a3b — — Integrated the craft-parts lifecycle to execute the charm builder via a craft-parts charm build plugin. Merged after two approvals and passing CI checks. Author plans to refactor plugin-level transformations in a follow-up.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Integrates the craft-parts lifecycle by executing the charm builder via a dedicated charm build plugin. The author will refactor plugin-level transformations in a follow-up PR.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#525 (confidence 78%)

    Follow-up PR merged as 0d78f540; it ran the parts lifecycle from the project directory for correct relative plugin resolution under CRAFT-505.

Related issues

Issue Project State Summary Similarity
#596 build: don't create implicit part if parts section specified (CRAFT-633) charmcraft merged PR #596 merged (merge commit 0dacae0a, bcbdd278) by cmatsuoka: charmcraft now skips the implicit `charm`/`bundle` part when an explicit `parts:` section exists (CRAFT-633), fixing #590; tests added.
77%
#2070 docs: fix build errors in craft-parts charmcraft closed Merged PR #2070, fixing Charmcraft ref and label build errors; remaining craft-parts errors depended on canonical/craft-parts#965.
76%
#3636 parts: integrate craft-parts (CRAFT-765) snapcraft merged Merged as ae8467056, integrating craft-parts for project-part validation and parts lifecycle processing (CRAFT-765).
76%
#453 build: spin off charm builder as a separate tool (CRAFT-373) charmcraft merged Merged #453 in commit 3e5eed05, extracting charm-building routines into a standalone CharmBuilder invoked by build; venv and pip enhancements were deferred.
75%
#525 parts: execute lifecycle from the project dir (CRAFT-505) charmcraft merged Merged in canonical/charmcraft#525 via 0d78f540, running the parts lifecycle from the project directory so relative plugin sources resolve when Charmcraft is launched elsewhere.
75%
#450 parts: add charm plugin (CRAFT-89) charmcraft closed Closed unmerged; CRAFT-89 landed via superseding PR #458, merged as 9dc20872 with implementation commit 437dab55.
74%
#1334 refactor(parts): move craft-parts related things into their own package charmcraft merged Merged PR #1334, moving craft-parts code from charmcraft/parts.py into a dedicated package with plugins and lifecycle logic split into separate modules.
74%
#25 parts: add PartsLifecycle support craft-application merged Merged PR #25 as commit 3fa6c712, adding PartsLifecycle support for CRAFT-1752 with tests and 100% diff coverage.
74%
#452 build: create charm builder tool (CRAFT-373) charmcraft closed Superseded by merged charmcraft#453, which moved charm-building logic to a standalone CharmBuilder; the venv and pip optimizations were deferred.
74%
#466 pack: implement bundle plugin (CRAFT-360) charmcraft merged Merged PR #466 via bfbd3078, adding the craft-parts bundle plugin and invoking the parts lifecycle during bundle packing.
74%