← Back to issue list

Keep all latest logs

View original Github issue

Metadata

Project
charmcraft
Number
#53
Type
issue
State
closed
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Log retention moved to craft-cli and was integrated into Charmcraft by merged PR #635 (d36b21d8), storing logs in the user log directory without configurable N.

Resolution: closed resolved

Reason: Log retention was delivered through craft-cli and integrated by merged PR canonical/charmcraft#635 at commit d36b21d8. The maintainer closed the issue saying it was already integrated.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This are several small changes: - start storing the logs in user's cache directory - don't remove the log file when charmcraft ends - keep latest N log files (`RotatingFileHandler`) - have a parameter in the config about that N

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Log retention moved to craft-cli and was integrated into Charmcraft by merged PR #635 (d36b21d8), storing logs in the user log directory without configurable N.
stealth/space-bunny-alpha — closed resolved Log retention moved to craft-cli and integrated into Charmcraft by merged PR #635 (commit d36b21d8), using the user log directory without configurable N.
stealth/space-bunny-alpha — closed resolved Log retention moved to craft-cli and integrated into Charmcraft by merged PR #635 (commit d36b21d8), using the user log directory without a configurable retention count.
stealth/space-bunny-alpha — closed resolved Log retention was delivered by the craft-cli library rather than in charmcraft itself; charmcraft adopted full craft-cli logging, including log files in the user's log dir, via PR #635 (merge d36b21d8).
stealth/space-bunny-alpha — closed resolved Log retention was implemented in craft-cli and integrated into Charmcraft by merged PR #635 (d36b21d8), using the user log dir and keeping recent files without configurable N.
qwen/qwen3.6-35b-a3b — — Integrated into craft-cli. Log handling now uses the log directory instead of cache, automatically retains recent files, and removes the configurable N limit. Closed as implemented.
qwen/qwen3.6-35b-a3b — — Log rotation and retention was integrated via craft-cli. Implementation stores logs in the system log directory and automatically retains recent files, omitting the originally planned configurable retention count.
qwen/qwen3.6-35b-a3b — — Integrated into the craft-cli library. Log rotation now stores files in the user log directory instead of cache, with a fixed retention policy replacing the configurable limit.
qwen3.6-35b-a3b-mtp-q6 — — Integrated by delegating log rotation to the craft-cli library. Logs are now stored in the user log directory instead of cache, with no configurable retention limit.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#635 (confidence 99%)

    Merged commit d36b21d8 integrated craft-cli functionality providing the requested persistent log retention.

Related issues

Issue Project State Summary Similarity
#49 charmcraft should log where it's logging to, and when the logfile is removed charmcraft closed Implemented via craft-cli#27 (3252b61) and Charmcraft PR #577; verbose runs now report the logfile path. Log retention in #53 removed the need for a deletion notice.
80%
#105 charmcraft-log files in /tmp charmcraft closed Closed without a Charmcraft fix after pytest retention was blamed; follow-up identified the directories as Charmcraft logs, but received no response.
72%