← Back to issue list

Formalize the command groups to be proper objects, not a tuple of values (CRAFT-560).

View original Github issue

Metadata

Project
charmcraft
Number
#562
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/charmcraft#562 via 08b79ab8 (implementation 75475c7b), formalizing command groups as objects and removing codenames ahead of the craft-cli split.

Resolution: closed resolved

Reason: PR #562 was merged into main by commit 08b79ab8. Commit 75475c7b converted tuple-based command groups into proper objects, removed codenames, and retained descriptions for user-facing output.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is a requirement for when the command groups will be defined and used by different codes (lib and app), after the split of part of `charmcraft` code to `craft-cli`. While doing this, I also removed the group's "codename" and just left the "description", which is what should be used for showing to the user.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#562 via 08b79ab8 (implementation 75475c7b), formalizing command groups as objects and removing codenames ahead of the craft-cli split.
stealth/space-bunny-alpha — closed resolved Merged PR #562, converting command groups from tuples to objects, removing codenames, and retaining descriptions for user-facing output ahead of the craft-cli split.
qwen/qwen3.6-35b-a3b — — Merged after approval. Command groups refactored from tuples to proper objects to prepare for the craft-cli split. Removed group codenames, retaining only descriptions for user display. Approved by one reviewer.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring that converts command groups from tuples to proper objects to support the craft-cli code split. Removed the group codename attribute, retaining only the description for user display.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#557 (confidence 93%)

    Merged prerequisite that removed command-group data from individual commands.

  • Related To: canonical/charmcraft#577 (confidence 85%)

    Subsequent craft-cli integration work that followed the planned code split.

Related issues

Issue Project State Summary Similarity
#557 Removed the command group from the command itself to simplify the whole structure (CRAFT-555). charmcraft merged Merged PR #557 removed group data from individual commands, simplifying Charmcraft's command structure; 12 files changed, mostly test updates.
75%
#4911 Refactor `command_group` usage snapcraft closed Migrated command groups to craft_cli.CommandGroup and removed the application override in commit e21b65be7 via PR #4934.
70%