Removed the command group from the command itself to simplify the whole structure (CRAFT-555).
Metadata
Current evaluation
Merged following reviewer approval. Simplified the architecture by removing the command group from the command itself (CRAFT-555). The update modified 12 files (+165/-173 lines), primarily adjusting tests while flagging core structural changes.
Suggested action: —
No scores available.
Issue body
This is a **big** branch, but 99% are silly and repetitive test changes.
I'll add comments around real code changes, to flag them.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following reviewer approval. Simplified the architecture by removing the command group from the command itself (CRAFT-555). The update modified 12 files (+165/-173 lines), primarily adjusting tests while flagging core structural changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a large update removing the command group from the command itself to simplify the structure, resolving CRAFT-555. The branch primarily contains repetitive test adjustments, with minimal core code changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactoring that removed the command group from the command itself to simplify the structure. The branch primarily contained repetitive test updates, with core logic changes clearly marked. Resolves CRAFT-555. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #562 Formalize the command groups to be proper objects, not a tuple of values (CRAFT-560). | charmcraft | merged | Merged after approval. Command groups refactored from tuples to proper objects to prepare for the craft-cli split. Removed group codenames, retaining only descriptions for user display. Approved by one reviewer. | |
| #827 Improve commands docstrings (CRAFT-1204). | charmcraft | merged | Merged improvements to command docstrings. Approved by one reviewer, the update modified three files with 38 additions and 32 deletions to enhance documentation clarity. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. | |
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files. | |
| #1572 refactor: remove unused extension command implementations | charmcraft | merged | Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files. | |
| #1419 refactor: remove non craft-application analyze command | charmcraft | merged | Merged refactoring that removes a superfluous non-craft-application version of the analyze command. Approved by three reviewers with zero unresolved comments. Modified seven files, deleting 339 lines and adding 135. | |
| #739 Hide the 'build' command and make 'pack' the common one (CRAFT-938). | charmcraft | merged | Merged after approval, this change hides the 'build' command and promotes 'pack' as the common command, resolving #720. The update modifies four files with four additions and three deletions. | |
| #798 Removed the long time deprecated 'build' command (CRAFT-1109). | charmcraft | merged | Merged removal of the deprecated 'build' command. Validator controls moved to Pack and booleans simplified. Changed 7 files (+92/-374). Approved and passed CI. Builder migration deferred to a follow-up PR. | |
| #1591 tests: remove regression test for command help | charmcraft | merged | Merged removal of a regression test for command help, as the craft-application base is now stable. Approved by two reviewers, the change deletes 93 lines across one file. |