Removed the command group from the command itself to simplify the whole structure (CRAFT-555).
Metadata
Current evaluation
Merged PR #557 removed group data from individual commands, simplifying Charmcraft's command structure; 12 files changed, mostly test updates.
Resolution: closed resolved
Reason: PR #557 was approved and merged as commit 911c1f9e, incorporating 4c66e020 to remove command groups from individual command definitions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is a **big** branch, but 99% are silly and repetitive test changes.
I'll add comments around real code changes, to flag them.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #557 removed group data from individual commands, simplifying Charmcraft's command structure; 12 files changed, mostly test updates. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #557 removed command-group data from individual commands, simplifying the command architecture; most of the 12-file change was repetitive test updates. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #557, removing command-group data from individual commands to simplify the architecture; implementation 4c66e020 landed via merge commit 911c1f9e. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged charmcraft PR #557 to remove command groups from individual commands and simplify command architecture; 12 files changed, mostly test updates. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following reviewer approval. Simplified the architecture by removing the command group from the command itself (CRAFT-555). The update modified 12 files (+165/-173 lines), primarily adjusting tests while flagging core structural changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a large update removing the command group from the command itself to simplify the structure, resolving CRAFT-555. The branch primarily contains repetitive test adjustments, with minimal core code changes. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#562
(confidence 90%)
Follow-up work formalized command groups as objects after this refactor.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #562 Formalize the command groups to be proper objects, not a tuple of values (CRAFT-560). | charmcraft | merged | Merged in canonical/charmcraft#562 via 08b79ab8 (implementation 75475c7b), formalizing command groups as objects and removing codenames ahead of the craft-cli split. | |
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| #4911 Refactor `command_group` usage | snapcraft | closed | Migrated command groups to craft_cli.CommandGroup and removed the application override in commit e21b65be7 via PR #4934. |