← Back to issue list

Refactor `command_group` usage

View original Github issue

Metadata

Project
snapcraft
Number
#4911
Type
issue
State
closed
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Closed and deferred to a scheduled pulse. Initial refactoring work began via a WIP commit to replace snapcraft.cli.CommandGroup with craft_cli.CommandGroup and remove overrides.

Suggested action:

No scores available.

Issue body

### What needs to get done Snapcraft should 1. stop [overriding](https://github.com/canonical/snapcraft/blob/f313611b9a3bb0a5d5eef9dfb12428e8157bbea8/snapcraft/application.py#L152) craft-application's [`command_group`](https://github.com/canonical/craft-application/blob/7eba6693af5466381659788053791281b1cf2235/craft_application/application.py#L163) property 3. Replace `snapcraft.cli.CommandGroup` with `craft_cli.CommandGroup` - context: https://github.com/canonical/snapcraft/pull/4830#discussion_r1624424293, https://github.com/canonical/craft-application/pull/359 ### Why it needs to get done Code cleanup

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed and deferred to a scheduled pulse. Initial refactoring work began via a WIP commit to replace snapcraft.cli.CommandGroup with craft_cli.CommandGroup and remove overrides.
qwen/qwen3.6-35b-a3b Superseded and deferred pending pulse scheduling. The maintainer noted the refactoring requires dedicated planning and provided a WIP commit for tracking. No merge or final implementation completed.
qwen/qwen3.6-35b-a3b Requested refactoring command_group usage for cleanup. The author started work but found it too complex, deferring implementation until scheduled in a sprint. A WIP commit was shared and the task was tracked internally via Jira.
qwen3.6-35b-a3b-mtp-q6 Abandoned pending future scheduling. The maintainer deferred the refactoring to a pulse cycle, leaving a WIP commit. The task closed without implementation or merge.
qwen3.6-35b-a3b-mtp-q6 Closed and abandoned pending scheduling. No fix or merge was completed; maintainer provided a WIP commit for future pulse scheduling.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#562 Formalize the command groups to be proper objects, not a tuple of values (CRAFT-560). charmcraft merged Merged after approval. Command groups refactored from tuples to proper objects to prepare for the craft-cli split. Removed group codenames, retaining only descriptions for user display. Approved by one reviewer.
71%