Refactor `command_group` usage
Metadata
Current evaluation
Migrated command groups to craft_cli.CommandGroup and removed the application override in commit e21b65be7 via PR #4934.
Resolution: closed resolved
Reason: The requested cleanup was completed in commit e21b65be7 and merged through PR #4934, replacing snapcraft.cli.CommandGroup usage and eliminating the command_group override.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
Snapcraft should
1. stop [overriding](https://github.com/canonical/snapcraft/blob/f313611b9a3bb0a5d5eef9dfb12428e8157bbea8/snapcraft/application.py#L152) craft-application's [`command_group`](https://github.com/canonical/craft-application/blob/7eba6693af5466381659788053791281b1cf2235/craft_application/application.py#L163) property
3. Replace `snapcraft.cli.CommandGroup` with `craft_cli.CommandGroup`
- context: https://github.com/canonical/snapcraft/pull/4830#discussion_r1624424293, https://github.com/canonical/craft-application/pull/359
### Why it needs to get done
Code cleanup
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Migrated command groups to craft_cli.CommandGroup and removed the application override in commit e21b65be7 via PR #4934. | |
| stealth/space-bunny-alpha | — | closed resolved | Migrated command groups to craft_cli.CommandGroup and removed the application override in commit e21b65be7, completing the cleanup. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and deferred to a scheduled pulse. Initial refactoring work began via a WIP commit to replace snapcraft.cli.CommandGroup with craft_cli.CommandGroup and remove overrides. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded and deferred pending pulse scheduling. The maintainer noted the refactoring requires dedicated planning and provided a WIP commit for tracking. No merge or final implementation completed. | |
| qwen/qwen3.6-35b-a3b | — | — | Requested refactoring command_group usage for cleanup. The author started work but found it too complex, deferring implementation until scheduled in a sprint. A WIP commit was shared and the task was tracked internally via Jira. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned pending future scheduling. The maintainer deferred the refactoring to a pulse cycle, leaving a WIP commit. The task closed without implementation or merge. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#4934
(confidence 98%)
PR #4934 contains the command-group cleanup resolving issue #4911.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #124 Make command groups more configurable | craft-application | closed | Closed as not planned: the requested command-group override was rejected because lifecycle and other default groups are now required for Craft applications. | |
| #557 Removed the command group from the command itself to simplify the whole structure (CRAFT-555). | charmcraft | merged | Merged PR #557 removed group data from individual commands, simplifying Charmcraft's command structure; 12 files changed, mostly test updates. | |
| #562 Formalize the command groups to be proper objects, not a tuple of values (CRAFT-560). | charmcraft | merged | Merged in canonical/charmcraft#562 via 08b79ab8 (implementation 75475c7b), formalizing command groups as objects and removing codenames ahead of the craft-cli split. |