← Back to issue list

Support cases of Store not respecting the API

View original Github issue

Metadata

Project
charmcraft
Number
#73
Type
issue
State
closed
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Store API resilience moved to craft-store when Charmcraft replaced its Store implementation in commit 35bb1cf4 via #565; the issue was later closed as handled there.

Resolution: closed superseded

Reason: The maintainer closed the issue with: "This is done by craft-store now." Repository history shows the Store implementation was replaced by craft-store in commit 35bb1cf4, associated with PR #565.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Even when Store answers correctly, we need to support response not being correctly formed. This is not only catching a possible malformed json, but also the fields in the API being missing or misnamed. After this, we would log in debug the problem found and present a nice message to the user (we need UnknownError for this, see #65) , instead of just crashing.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Store API resilience moved to craft-store when Charmcraft replaced its Store implementation in commit 35bb1cf4 via #565; the issue was later closed as handled there.
stealth/space-bunny-alpha — closed superseded Handled in the new craft-store project by adding graceful handling for malformed or unexpected Store API responses; the Charmcraft issue was closed.
stealth/space-bunny-alpha — closed superseded Closed as handled by the new craft-store project, which added graceful handling of malformed or unexpected Store API responses.
qwen/qwen3.6-35b-a3b — — Resolved via craft-store, which now gracefully handles malformed or misaligned Store API responses. The issue is closed as the required error handling and user-friendly messaging are implemented externally.
qwen/qwen3.6-35b-a3b — — Closed as resolved by craft-store, which now handles malformed or misaligned API responses gracefully, eliminating the need for local error handling.
qwen/qwen3.6-35b-a3b — — Resolved by craft-store, which now handles malformed or missing API fields gracefully. Error handling, debug logging, and user-friendly messaging replace previous crash behavior.
qwen3.6-35b-a3b-mtp-q6 — — Closed. Graceful handling of malformed or misaligned Store API responses is now implemented in craft-store, resolving this requirement.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#565 (confidence 92%)

    PR #565 replaced Charmcraft's Store implementation with craft-store; commit 35bb1cf4 records that migration.

Related issues

Issue Project State Summary Similarity
#3684 legacy storeapi: use craft-store snapcraft closed Closed in favor of #3692, which merged the legacy storeapi migration to craft-store as 15b55daa8 (merge 5a850ca04).
71%
#565 store: replace implementation with craft-store (CRAFT-491) charmcraft merged Merged #565 into main, replacing Charmcraft's store implementation with craft-store for CRAFT-491 (merge commit 70ba8e28).
70%