← Back to issue list

Fix the default template's tests

View original Github issue

Metadata

Project
charmcraft
Number
#770
Type
pull request
State
closed
Author
jnsgruk
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; the init-template test fix landed through merged PR #771 (commit d08fe071, merge cf0c4c59).

Resolution: closed superseded

Reason: PR #770 was closed without merge, CI, review, or maintainer comments. Its fix was merged as canonical/charmcraft#771 in d08fe071, restoring the init-template tests and bumping the development ops dependency.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The introduction of more realistic container networking in the test suite broke the `init` template tests. I know we're looking at updating the template anyway, but this should be considered a bug fix in the mean time. Perhaps we could introduce a CI test that runs `charmcraft init; pip install -r requirements-dev.txt; ./run_tests` to ensure this doesn't get broken again?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; the init-template test fix landed through merged PR #771 (commit d08fe071, merge cf0c4c59).
stealth/space-bunny-alpha — closed stale The two-line fix for the default init template tests was closed unmerged, with review pending, no CI checks, and no maintainer comments.
stealth/space-bunny-alpha — closed resolved PR #771 was merged (cf0c4c59), fixing the init template’s tests after networking changes and updating the development ops dependency.
qwen/qwen3.6-35b-a3b — — Closed without merging. The fix for broken init template tests caused by container networking changes was abandoned, likely superseded by planned template updates. No reviews or CI checks were completed.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merge. The pull request addressed test failures caused by updated container networking in the init template. Likely abandoned or superseded by planned template updates, with no resolution implemented.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#771 (confidence 99%)

    Merged replacement for #770, from the same contributor branch, with merge commit cf0c4c59.

Related issues

Issue Project State Summary Similarity
#1540 fix: template integration tests charmcraft merged Merged PR #1540 as commit f3f82031, updating integration-test templates to use charmcraft.yaml instead of metadata.yaml and completing the stalled change from #1468.
71%
#771 Fix the tests in the init template charmcraft merged Merged PR #771 fixed init-template tests broken by realistic container networking and bumped the dev `ops` dependency so generated charm tests pass.
70%