← Back to issue list

Fix the tests in the init template

View original Github issue

Metadata

Project
charmcraft
Number
#771
Type
pull request
State
merged
Author
jnsgruk
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #771 fixed init-template tests broken by realistic container networking and bumped the dev `ops` dependency so generated charm tests pass.

Resolution: closed resolved

Reason: PR charmcraft#771 was approved and merged. It updated the init-template tests and the `ops` version in `requirements-dev.txt`, resolving the reported test failure.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The introduction of more realistic container networking in the test suite broke the init template tests. I know we're looking at updating the template anyway, but this should be considered a bug fix in the mean time. In order for the `charmcraft` tests to pass, the `ops` version in `requirements-dev.txt` also needed bumping. Perhaps we could introduce a CI test that runs charmcraft init; pip install -r requirements-dev.txt; ./run_tests to ensure this doesn't get broken again?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #771 fixed init-template tests broken by realistic container networking and bumped the dev `ops` dependency so generated charm tests pass.
stealth/space-bunny-alpha — closed resolved Merged #771, fixing init-template tests disrupted by realistic container networking and bumping the ops development dependency.
stealth/space-bunny-alpha — closed resolved Merged #771, fixing init-template tests broken by container-networking changes and bumping the dev ops dependency.
stealth/space-bunny-alpha — closed resolved Merged fix restored init-template tests after realistic container networking changed test behavior; also bumped the ops version in requirements-dev.txt so charmcraft tests pass.
stealth/space-bunny-alpha — closed resolved PR #771 merged to repair init template tests disrupted by realistic container networking and bumped the development dependency on ops so the charmcraft tests pass.
qwen/qwen3.6-35b-a3b — — Merged a fix for init template tests broken by container networking changes. Updated the ops dependency in requirements-dev.txt to resolve failures. Approved by one reviewer, passed CI, and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for broken init template tests caused by container networking updates. Resolved by updating the ops version in requirements-dev.txt. Author recommended adding a CI test to prevent future regressions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1540 fix: template integration tests charmcraft merged Merged PR #1540 as commit f3f82031, updating integration-test templates to use charmcraft.yaml instead of metadata.yaml and completing the stalled change from #1468.
75%
#770 Fix the default template's tests charmcraft closed Closed unmerged; the init-template test fix landed through merged PR #771 (commit d08fe071, merge cf0c4c59).
70%