Do not modify the charm's project when packing using the reactive plugin (CRAFT-928).
Metadata
Current evaluation
Merged to resolve issue #693. The change prevents the reactive plugin from modifying the charm's project during packing. Approved by one reviewer with zero unresolved comments. Two files modified, netting a 21-line reduction.
Suggested action: —
No scores available.
Issue body
Fixes #693.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to resolve issue #693. The change prevents the reactive plugin from modifying the charm's project during packing. Approved by one reviewer with zero unresolved comments. Two files modified, netting a 21-line reduction. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing the reactive plugin from modifying the charm's project during packing, resolving CRAFT-928 and issue #693. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve issue #693 and CRAFT-928. The change prevents the reactive plugin from modifying the charm project during packing, ensuring correct build isolation and artifact generation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #693 Charms packed using the reactive plugin shows dirty version | charmcraft | closed | Fixed by modifying the reactive plugin to stop removing charmcraft.yaml before building. This prevented git describe from incorrectly marking packed charm versions as dirty. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Implemented reactive plugin functionality using the charm tool, addressing CRAFT-699. Merged after approval, modifying 11 files with 499 additions and 8 deletions. | |
| #821 5.5.0 changes pack semantics if the project file has different metadata | craft-application | open | Charmcraft pack skips repacking when only charmcraft.yaml metadata (e.g. summary, config, platforms) changes, leaving a stale .charm. Triaged and moved to craft-application; workaround is clean. Conditional repacking support added in #1111. | |
| #808 Consolidate the charm plugin configuration in its properties (CRAFT-1156). | charmcraft | merged | Merged consolidation of charm plugin configuration into its properties. Approved by two reviewers, the change simplifies implementation and clarifies validation choices. Updated six files with a net reduction of 318 lines. | |
| #411 build: pack charm in provided environment when using bases (CRAFT-313) | charmcraft | merged | Merged implementation for packing charms in provided environments per bases configuration (CRAFT-313). Approved by two reviewers, modifying two files (+175/-30). Future work will add verbose and quiet mode flag support. | |
| #1151 build: do not create metafiles when using reactive | charmcraft | merged | Merged changes preventing metafile creation for the reactive framework due to charmcraft format incompatibility. Resolves issue #1150. Approved by one reviewer, passed CI, and modified one file (+6/-3). | |
| #324 Provide the building charms functionality through the pack command. | charmcraft | merged | Merged. Implements building charms functionality via the pack command. Approved by three reviewers, modifying four files (+219/-30 lines). | |
| #866 reactive_plugin: Fix charm tools version validation | charmcraft | merged | Merged fix for brittle charm-tools version validation in reactive_plugin, resolving issue #864. Approved by one reviewer, passed CI, and updated two files with 12 additions and 6 deletions. | |
| #450 parts: add charm plugin (CRAFT-89) | charmcraft | closed | Abandoned without merging. The author intended to submit a revised version to execute a charm building tool, leaving this charm plugin implementation unresolved due to pending review comments. |