Do not modify the charm's project when packing using the reactive plugin (CRAFT-928).
Metadata
Current evaluation
Merged PR #777 (CRAFT-928) via commit bac1d03b, preventing reactive packing from modifying the charm project and fixing #693's incorrect dirty versions.
Resolution: closed resolved
Reason: PR #777 was merged into main as commit bac1d03b. The change prevents reactive packing from removing charmcraft.yaml, resolving the dirty-version behavior tracked in #693.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes #693.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #777 (CRAFT-928) via commit bac1d03b, preventing reactive packing from modifying the charm project and fixing #693's incorrect dirty versions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #777 for CRAFT-928, fixing #693 by keeping the reactive plugin from modifying the charm project during packing and preventing incorrect dirty versions. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to resolve issue #693. The change prevents the reactive plugin from modifying the charm's project during packing. Approved by one reviewer with zero unresolved comments. Two files modified, netting a 21-line reduction. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing the reactive plugin from modifying the charm's project during packing, resolving CRAFT-928 and issue #693. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#693
(confidence 100%)
PR #777 explicitly fixes the reactive packing dirty-version issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #693 Charms packed using the reactive plugin shows dirty version | charmcraft | closed | Fixed in merged PR #777 (CRAFT-928): reactive packing now leaves charmcraft.yaml in place, preventing charm build from adding a -dirty version. | |
| #821 5.5.0 changes pack semantics if the project file has different metadata | craft-application | open | Metadata-only charmcraft.yaml edits were skipped as "Already packed," leaving stale .charm artifacts; Charmcraft PR #2890 is reported to fix repacking after the edit. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8. | |
| #872 charm artifacts from reactive plugin are missing valuable build metadata | charmcraft | open | Reactive charm artifacts omit .build.manifest and charmtool-version; an exact fix is proposed in open PR charmcraft#2502 and remains under review. | |
| #2055 `no hooks nor dispatch file` after packing | charmcraft | closed | Fixed by merged PR #2073 (commit a93a2d91): Charmcraft now rejects platform-based charm projects without parts instead of producing an invalid metadata-only charm. | |
| #2245 fix(reactive): don't overwrite config.yaml from a reactive charm | charmcraft | merged | Merged PR #2245 (commit aa28f0dc, CRAFT-4206) stops the package service from overwriting a config.yaml generated by a reactive charm, fixing #2194. | |
| #2890 feat: skip repacking if project is not changed | charmcraft | merged | Merged PR implementing metadata mediation for config.yaml and actions.yaml so charmcraft skips repacking unchanged projects; fixes #2858 and canonical/craft-application#821. | |
| #2498 fix: `charmcraft pack --project-dir` with metadata.yaml | charmcraft | closed | Closed unmerged; superseded by #2644, which fixed metadata lookup for --project-dir and shipped in Charmcraft 4.2.1. |