← Back to issue list

plugins: reactive using charm tool (CRAFT-699)

View original Github issue

Metadata

Project
charmcraft
Number
#613
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8.

Resolution: closed resolved

Reason: The pull request was merged into main via commit 32c8650a ("Merge pull request #613 from canonical/charm-tools-plugin"), landing the reactive plugin (charmcraft/parts/plugins/_reactive.py, later moved under parts and extended by follow-ups such as #863, #866 and #869).

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#613, implementing CRAFT-699 with a reactive plugin based on the charm tool; 11 files changed (+499/-8).
qwen/qwen3.6-35b-a3b — — Implemented reactive plugin functionality using the charm tool, addressing CRAFT-699. Merged after approval, modifying 11 files with 499 additions and 8 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation of reactive plugin functionality using the charm tool, resolving CRAFT-699. Integrated directly by maintainer sergiusens with no additional comments or revisions required.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: charmcraft#610 (confidence 88%)

    Earlier 'many: add reactive charm plugin' attempt; #613 was the merged implementation

  • Related To: charmcraft#863 (confidence 80%)

    Follow-up adding reactive-charm-build-arguments for passing options to charm build

  • Related To: charmcraft#866 (confidence 75%)

    Follow-up fixing charm tool version validation in the plugin introduced here

  • Related To: charmcraft#869 (confidence 72%)

    Follow-up fixing returncode checking of the charm tool invocation added by this PR

  • Related To: charmcraft#881 (confidence 65%)

    Later fix for flaky reactive integration tests covering this plugin's behaviour

Related issues

Issue Project State Summary Similarity
#610 many: add reactive charm plugin charmcraft closed PR #610 (charm-tools-based reactive plugin) was closed unmerged on 2021-12-14 by sergiusens in favor of #613, which reimplemented the plugin on the charm tool (CRAFT-699) and merged as 32c8650a.
86%
#866 reactive_plugin: Fix charm tools version validation charmcraft merged Merged PR #866 as commit 35ec089e (merge c40c30c2), replacing brittle charm-tools version parsing with JSON output and fixing #864.
80%
#864 reactive plugin charm tools version validation code is britle charmcraft closed Fixed by merged PR #866: commit 35ec089e updated reactive-plugin charm-tools validation to use JSON output; merge c40c30c2 closed #864.
79%
#863 reactive_plugin: Support arguments to charm build command charmcraft merged Merged in charmcraft PR #863 via commit a5f200b1, adding reactive-charm-build-arguments so the reactive plugin can pass options to charm build; fixes #809.
74%
#450 parts: add charm plugin (CRAFT-89) charmcraft closed Closed unmerged; CRAFT-89 landed via superseding PR #458, merged as 9dc20872 with implementation commit 437dab55.
74%
#1326 fix(test): fix reactive plugin test if 'charm' tool is installed charmcraft merged Merged test-only fix making reactive plugin tests deterministic when the charm executable is installed, via PR #1326 and commit 4a573702.
74%
#869 reactive_plugin: Properly check returncode from charm tool charmcraft merged Merged in commit 7046f61d (merge ecce30c6), fixing reactive_plugin to validate the charm tool return code and always log it; resolves #804.
72%
#693 Charms packed using the reactive plugin shows dirty version charmcraft closed Fixed in merged PR #777 (CRAFT-928): reactive packing now leaves charmcraft.yaml in place, preventing charm build from adding a -dirty version.
72%
#777 Do not modify the charm's project when packing using the reactive plugin (CRAFT-928). charmcraft merged Merged PR #777 (CRAFT-928) via commit bac1d03b, preventing reactive packing from modifying the charm project and fixing #693's incorrect dirty versions.
72%
#809 Reactive plugin doesn't allow for other `charm` cli arguments. charmcraft closed Resolved by merged PR #863 (merge commit a5f200b1): reactive builds can now pass charm build options such as --layer-index via reactive-charm-build-arguments.
72%