chore: fix linting
Metadata
Current evaluation
Merged PR #369 removed two redundant casts (1 file, +2/-2), fixing Ty linting; the lint/files check passed.
Resolution: closed resolved
Reason: PR #369 was approved and merged, with its lint/files check passing after the redundant casts were removed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Ty is complaining about [redundant casting](https://github.com/canonical/imagecraft/actions/runs/28358213582/job/84006318869?pr=368)
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #369 removed two redundant casts (1 file, +2/-2), fixing Ty linting; the lint/files check passed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 5363d6d: small lint-only follow-up removing two redundant type casts that Ty flagged on PR #368; approved by 2 reviewers and lint/files passed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #368 replaced two redundant casts to satisfy Ty linting; lint passed, while some spread and OSV-scanner checks failed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #369 as commit 5363d6d, replacing redundant casts to satisfy Ty linting; the lint/files check passed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #369 (commit 5363d6d), removing two redundant casts flagged by ty; lint and tests passed, with approval from two reviewers. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving redundant casting linting errors flagged by Ty. Approved by two reviewers. Changes involved minimal edits (+2/-2 lines) across one file. CI lint and test checks passed prior to merge. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/imagecraft#368
(confidence 95%)
The Ty redundant-casting failure was reported from the CI run for PR #368.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1099 chore: fix linting | craft-application | merged | Merged as 4c674c21, updating two files to clear Ty unused-directive lint errors; lint/files passed and review was approved. | |
| #585 chore(linter): misc fixes | craft-parts | merged | Merged PR #585 with miscellaneous linter fixes across 125 files, preserving individual commits rather than squashing, as requested. | |
| #359 chore(lint): update linters and fix linting issues with new rules | craft-parts | merged | Merged PR #359 in commit e7b93bde, updating linters and fixing violations introduced by the new rules across 13 files. | |
| #439 chore(linter): misc fix | rockcraft | merged | Merged PR #439, applying miscellaneous linter fixes across 16 files, including a Pyright error exposed after rebasing onto main. | |
| #375 chore(lint): Remove trailing whitespace | rockcraft | merged | Merged PR #375 removed trailing whitespace from one file (+4/-4), resolving yamllint complaints; landed as commit 777df7e3. | |
| #2028 chore: two small non-code changes | charmcraft | merged | Merged PR #2028 incorporated two small non-code updates across two files (+5/-2), with approval from two reviewers. | |
| #2682 chore: delete some dead code | charmcraft | merged | Merged PR #2682 that removes 19 lines of dead code related to the project-service cast issue fixed in #2681. | |
| #529 chore: fix doc and yaml linting | craft-parts | merged | Merged #529 as commit 81dc87bd, fixing documentation and YAML linting in three files. Verification used tox -m lint; lint enforcement in CI remained disabled. | |
| #242 style: fix ty linting error | craft-platforms | merged | Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce. | |
| #6431 chore(merge): 9.1.2 into main | snapcraft | closed | Merged release branch 9.1.2 into main via commit 264420ba4; the remaining lint/files failure was attributed to an unrelated ty update. |