← Back to issue list

chore: fix linting

View original Github issue

Metadata

Project
imagecraft
Number
#369
Type
pull request
State
merged
Author
smethnani
Labels
Created
Updated
Closed

Current evaluation

Merged after resolving redundant casting linting errors flagged by Ty. Approved by two reviewers. Changes involved minimal edits (+2/-2 lines) across one file. CI lint and test checks passed prior to merge.

Suggested action:

No scores available.

Issue body

Ty is complaining about [redundant casting](https://github.com/canonical/imagecraft/actions/runs/28358213582/job/84006318869?pr=368) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after resolving redundant casting linting errors flagged by Ty. Approved by two reviewers. Changes involved minimal edits (+2/-2 lines) across one file. CI lint and test checks passed prior to merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 5
Confidence: 90
needs review Updates Python code to resolve ty linter warnings regarding redundant casting. Currently awaiting CI validation and maintainer review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1099 chore: fix linting craft-application merged Merged a linting fix to resolve unused directives flagged by Ty. The update modified two files, received approval from two reviewers, passed CI validation, and was successfully integrated.
91%
#585 chore(linter): misc fixes craft-parts merged Merged linter fixes across 125 files. Approved by two reviewers and merged without squashing per maintainer request.
83%
#1215 chore: linting rockcraft merged Merged a linting fix replacing an unnecessary str() call with a string literal in tests/unit/test_project.py to resolve ruff error UP018. Approved by two reviewers and merged.
82%
#375 chore(lint): Remove trailing whitespace rockcraft merged Merged changes removing trailing whitespace from one file to satisfy linters like yamllint. Approved by two reviewers, passed CI, and modified four lines.
81%
#328 chore: change type checking to use `ty` imagecraft merged Switched type checking to ty, resolving issue 263. Merged after two approvals and passing CI checks. Changes span three files with minimal code adjustments.
80%
#443 chore(linter): fix some annotation errors rockcraft merged Merged maintainer changes that resolved linter annotation errors across 14 files. The +97/-55 line update received approval from two reviewers and was successfully integrated into the codebase.
80%
#359 chore(lint): update linters and fix linting issues with new rules craft-parts merged Merged after updating linters and fixing linting issues under new rules. The change modified 13 files and was approved by one reviewer before integration.
80%
#439 chore(linter): misc fix rockcraft merged Merged linter chore PR fixing miscellaneous issues and an unexpected pyright error from a rebase onto main. Approved by two reviewers, changes span 16 files with 86 additions and 76 deletions.
80%
#446 chore(linter): fix some format errors rockcraft open Linter formatting fix across 54 files. Approved by 1 reviewer but has 8 unresolved review comments. Last activity 386 days ago.
79%
#529 chore: fix doc and yaml linting craft-parts merged Merged after two approvals and passing CI. Resolves documentation and YAML linting issues across three files. Net reduction of two lines. Local verification available via tox lint.
78%