style: fix ty type confusion
Metadata
Current evaluation
Approved with passing CI, but craft-application#1182 was closed unmerged without explanation; its two-line ValueType annotation fix never landed.
Resolution: closed stale
Reason: The PR received two approvals and all completed CI checks passed; only snap-tests remained pending. It was nevertheless closed without being merged, with no closing rationale or replacement identified.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Looks like ty doesn't think list[dict[str, str | None]] is a valid ValueType.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Approved with passing CI, but craft-application#1182 was closed unmerged without explanation; its two-line ValueType annotation fix never landed. | |
| stealth/space-bunny-alpha | — | closed stale | Approved craft-application#1182 corrected ty’s ValueType annotation, but the unmerged PR was closed without a stated explanation; reported CI was passing except pending snap-tests. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
11
Complexity:
5
Confidence:
85
Actionability:
80
|
needs review | Fixes a type annotation issue where ty rejects list[dict[str, str | None]] as a valid ValueType. All CI checks passing, awaiting review. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1727 style: ty 0.0.82 | craft-parts | closed | PR #1727 updated style for ty 0.0.82 and received two approvals, but was closed unmerged after three architecture-specific Java CI jobs failed. | |
| #485 style: ty 0.0.79 | craft-cli | closed | Merged into main: a +2/-2 line one-file style fix for the new error reported by the ty 0.0.79 type checker, by maintainer mr-cal; review approved, all 25 CI checks green. Ty was later bumped to 0.0.82 in craft-parts#1727. | |
| #910 style: fix ty error | craft-providers | merged | Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed. |