← Back to issue list

style: ty 0.0.79

View original Github issue

Metadata

Project
craft-cli
Number
#485
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main: a +2/-2 line one-file style fix for the new error reported by the ty 0.0.79 type checker, by maintainer mr-cal; review approved, all 25 CI checks green. Ty was later bumped to 0.0.82 in craft-parts#1727.

Resolution: closed resolved

Reason: The PR was approved by a reviewer and merged with every CI check passing (lint, fast/slow tests on all Python versions and architectures, CLA, zizmor); it applies the code change needed to silence a new ty 0.0.79 diagnostic. Follow-up canonical/craft-parts#1727 upgrades ty from 0.0.79 to 0.0.82.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Fixes a new ty error.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into main: a +2/-2 line one-file style fix for the new error reported by the ty 0.0.79 type checker, by maintainer mr-cal; review approved, all 25 CI checks green. Ty was later bumped to 0.0.82 in craft-parts#1727.
stealth/space-bunny-alpha — closed resolved Merged to main as commit 6d3dca9 "style: ty 0.0.79 (#485)" — a 2-line style fix for a new ty 0.0.79 linter error, all 26 CI checks passing. Later superseded by craft-parts#1727 (ty 0.0.82).
stealth/space-bunny-alpha — closed resolved Merged the ty 0.0.79 update with all CI checks passing; canonical/craft-parts#1727 subsequently upgrades ty from 0.0.79 to 0.0.82.
stealth/space-bunny-alpha — closed resolved Merged the two-line fix for a new ty 0.0.79 error after approval; all lint and test checks passed.
qwen/qwen3.6-35b-a3b — — Merged a minor style fix addressing a new typo error. The pull request passed all CI checks and received approval before being closed.
qwen/qwen3.6-35b-a3b
Impact: 10
Quick Win: 10
Staleness: 0
Complexity: 5
Confidence: 90
needs review Updates ty linter to 0.0.79 and fixes a new lint error. Approved by 1 reviewer, all CI checks passing, 2-line change.
qwen/qwen3.6-35b-a3b
Impact: 15
Quick Win: 14
Staleness: 5
Complexity: 10
Confidence: 75
needs review Fixes a new ty type-checking error with a 2-line change. Fresh PR from maintainer, all test CI jobs failing.

Update history

Date Change
closed
updated
updated
created

Related work

  • Related To: canonical/craft-parts#1727 (confidence 80%)

    Follow-up 'style: ty 0.0.82' PR in craft-parts that upgrades ty from 0.0.79, showing this bump was part of a rolling linter upgrade chain.

Related issues

Issue Project State Summary Similarity
#6280 style: ty 0.0.44 snapcraft merged Merged PR #6280 in commit 8b45efc80, applying ty 0.0.44 style updates after two approvals; unrelated CI failures did not block the merge.
80%
#1727 style: ty 0.0.82 craft-parts closed PR #1727 updated style for ty 0.0.82 and received two approvals, but was closed unmerged after three architecture-specific Java CI jobs failed.
77%
#6498 style: ty 0.0.87, ruff 0.17.0 snapcraft merged Merged PR #6498, cherry-picking style fixes from #6493 onto hotfix/9.2 to update ty to 0.0.87 and ruff to 0.17.0.
76%
#1361 style: suppress ty warning rockcraft merged One-line style PR adding a ty type-ignore to silence ty 0.0.79's false-positive warning that user_files["shadow"] is always "". Approved by one reviewer and merged (+1/-1, 1 file); source-spread-tests was the only red check.
76%
#1267 style(type): make `ty` happy with the `craft_parts` directory craft-parts merged Merged #1267 in commit 2ca02baf, applying type/style fixes across five craft_parts files with all CI checks passing; remaining test-directory typing work stayed in astral-sh/ty#445.
75%
#139 style(type): fix typing issues found by ty craft-platforms merged Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553.
74%
#1126 style: fix ty errors craft-application merged Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors.
74%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
74%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
73%
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
73%