← Back to issue list

style: fix ty error

View original Github issue

Metadata

Project
craft-providers
Number
#910
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.

Resolution: closed resolved

Reason: The approved one-line change was merged as commit 30fc806 to suppress the reported ty false positive. All listed tests, lint, smoke, security, and policy checks passed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Silences an error from ty that I believe may be a false positive. I reported it [here](https://github.com/astral-sh/ty/issues/2812)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
qwen/qwen3.6-35b-a3b — closed resolved Merged a one-line change to silence a ty linter false positive, with the upstream issue tracked at astral-sh/ty#2812.

Update history

Date Change
created

Related work

  • Related To: ty#2812 (confidence 100%)

    Upstream ty issue cited in the PR as the suspected false positive.

Related issues

Issue Project State Summary Similarity
#2957 style: suppress ty diagnostics that block CI charmcraft closed Merged PR #2957 to fix CI `lint-ty` failures by suppressing 22 diagnostics and fixing a redundant cast.
80%
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
78%
#27 ci: type check with ty craft-artifacts merged Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20.
78%
#2961 style: suppress ty diagnostics that block CI charmcraft merged Merged PR #2961 adds ty-specific lint ignores to match existing pyright/mypy configurations and removes a redundant cast in _expand_base, resolving CI blocks.
77%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
77%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
77%
#6280 style: ty 0.0.44 snapcraft merged Merged PR #6280 in commit 8b45efc80, applying ty 0.0.44 style updates after two approvals; unrelated CI failures did not block the merge.
77%
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
76%
#139 style(type): fix typing issues found by ty craft-platforms merged Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553.
75%
#335 fix(lint): suppress ty imagecraft merged Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed.
75%