← Back to issue list

test: add helpers to manipulate fetch-service sessions

View original Github issue

Metadata

Project
craft-application
Number
#1201
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main as c80ce0e1: PR #1201 added test helpers for creating and tearing down fetch-service sessions, replacing repetitive curl calls and file manipulation.

Resolution: closed resolved

Reason: PR #1201 was approved by two reviewers and merged as commit c80ce0e1. It centralizes fetch-service session setup and cleanup, making tests clearer and less repetitive.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Creating and tearing down fetch-service sessions require a bunch of curl calls and file manipulations that get noisy and distract from the purpose of the test itself. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into main as c80ce0e1: PR #1201 added test helpers for creating and tearing down fetch-service sessions, replacing repetitive curl calls and file manipulation.
qwen/qwen3.8-27b — closed resolved Merged test-only PR adding helpers to create and tear down fetch-service sessions, replacing noisy curl calls and file manipulations in tests. +189/-74 across 3 files, approved by 2 reviewers with CI passing.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 10
Complexity: 30
Confidence: 75
Actionability: 70
needs review Adds test helpers to simplify fetch-service session creation/teardown in tests, reducing noisy curl calls and file manipulations. Approved by 2 reviewers; 2 unresolved comments and OSV-scanner CI check failing.
stealth/space-bunny-alpha
Impact: 25
Quick Win: 13
Complexity: 28
Confidence: 66
Actionability: 74
needs review Adds test helpers for creating/tearing down fetch-service sessions so spread tests avoid noisy inline curl calls and file manipulation. Test-only change (+189/-74, 3 files), approved by 1 reviewer; all CI green except a pre-existing OSV-scanner failure.

Update history

Date Change
merged
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1181 feat(test): support fetch-service sessions in 'test' craft-application closed PR #1181 by tigarmo was merged (commit ca7ec04c), adding CRAFT_USE_EXTERNAL_FETCH_SERVICE support to 'craft test' so spread execution proxies runner traffic (apt/snapd) through a fetch-service session. All CI checks passed.
75%
#1199 feat: support CRAFT_TEST_FETCH_SERVICE_SESSIONS craft-application merged Merged PR #1199 (commit e2f9f3ba) adds CRAFT_TEST_FETCH_SERVICE_SESSIONS so tests use a fetch-service session URL instead of HTTP_PROXY; shipped in craft-application 7.5.0 with docs, unit and spread tests.
72%