← Back to issue list

feat: support CRAFT_TEST_FETCH_SERVICE_SESSIONS

View original Github issue

Metadata

Project
craft-application
Number
#1199
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1199 (commit e2f9f3ba) adds CRAFT_TEST_FETCH_SERVICE_SESSIONS so tests use a fetch-service session URL instead of HTTP_PROXY; shipped in craft-application 7.5.0 with docs, unit and spread tests.

Resolution: closed resolved

Reason: The PR was merged by a maintainer with 2 approvals and landed as commit e2f9f3ba, adding the env-var handling in craft_application/services/testing.py plus a 7.5.0 changelog entry, docs in reference/fetch-service.rst and unit/spread tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If set, this environment variable contains the url for the fetch-service session that should be used when running tests, *instead* of HTTP_PROXY & friends. Although the variable is plural, the implementation only supports a single url for now. It's left pluralized for the near-future improvement of individual sessions per test runner. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1199 (commit e2f9f3ba) adds CRAFT_TEST_FETCH_SERVICE_SESSIONS so tests use a fetch-service session URL instead of HTTP_PROXY; shipped in craft-application 7.5.0 with docs, unit and spread tests.
qwen/qwen3.8-27b — closed resolved Merged feature adding CRAFT_TEST_FETCH_SERVICE_SESSIONS env var support, allowing tests to use a specific fetch-service session URL instead of HTTP_PROXY. Approved by 2 reviewers; diff spans 5 files (+136/-60).
qwen/qwen3.8-27b — closed resolved Merged feature PR adding CRAFT_TEST_FETCH_SERVICE_SESSIONS env var support, letting tests use a fetch-service session URL instead of HTTP_PROXY. Approved by 2 reviewers; +136/-60 across 5 files.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 19
Complexity: 30
Confidence: 70
Actionability: 60
needs review Adds CRAFT_TEST_FETCH_SERVICE_SESSIONS env var so the test command can use a fetch-service session URL directly instead of HTTP_PROXY and friends. Small diff (+136/-60, 5 files), approved by 2 reviewers, 3 unresolved comments, most CI jobs still pending.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 15
Complexity: 40
Confidence: 70
Actionability: 55
needs review Adds CRAFT_TEST_FETCH_SERVICE_SESSIONS env var so 'test' uses an external fetch-service session URL instead of HTTP_PROXY; approved with 4 unresolved review comments; CI mostly green except snap-tests (openstack) and OSV-scanner.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 15
Complexity: 40
Confidence: 70
Actionability: 55
needs review Adds CRAFT_TEST_FETCH_SERVICE_SESSIONS so the test command can use a fetch-service session URL directly instead of host proxy vars. 5 files, +136/-60. CI mostly green; openstack snap-tests and OSV-scanner failing; 2 unresolved review comments.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 15
Complexity: 40
Confidence: 70
Actionability: 55
keep open Adds CRAFT_TEST_FETCH_SERVICE_SESSIONS env var so 'test' uses a fetch-service session URL instead of HTTP_PROXY vars; +136/-60 in 5 files, CI mostly pending, OSV-scanner failing, 1 unresolved review comment.
stealth/space-bunny-alpha
Impact: 35
Quick Win: 13
Complexity: 40
Confidence: 68
Actionability: 62
needs review Maintainer-authored feature adding CRAFT_TEST_FETCH_SERVICE_SESSIONS so 'craft test' proxies spread runner traffic through an external fetch-service session URL instead of HTTP_PROXY; 7 files, +317/-126, 1 day old, awaiting review

Update history

Date Change
merged
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1181 feat(test): support fetch-service sessions in 'test' craft-application closed PR #1181 by tigarmo was merged (commit ca7ec04c), adding CRAFT_USE_EXTERNAL_FETCH_SERVICE support to 'craft test' so spread execution proxies runner traffic (apt/snapd) through a fetch-service session. All CI checks passed.
86%
#837 feat: "support" existing fetch-service sessions craft-application merged Merged in craft-application#837 as d03d8b43, adding external fetch-service and proxy-certificate environment support as groundwork; the PR explicitly delivered only partial packing support.
78%
#490 feat: allow strict/permissive fetch-service sessions craft-application merged Merged PR #490 as d327e604, requiring --use-fetch-service to select strict or permissive sessions and fixing craft-application#487.
74%
#1201 test: add helpers to manipulate fetch-service sessions craft-application merged Merged into main as c80ce0e1: PR #1201 added test helpers for creating and tearing down fetch-service sessions, replacing repetitive curl calls and file manipulation.
72%