← Back to issue list

feat(test): support fetch-service sessions in 'test'

View original Github issue

Metadata

Project
craft-application
Number
#1181
Type
pull request
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

PR #1181 by tigarmo was merged (commit ca7ec04c), adding CRAFT_USE_EXTERNAL_FETCH_SERVICE support to 'craft test' so spread execution proxies runner traffic (apt/snapd) through a fetch-service session. All CI checks passed.

Resolution: closed resolved

Reason: The pull request was approved by two reviewers with all CI checks passing and was merged into main as commit ca7ec04c, delivering the requested fetch-service session support in the test command (+405/-4 across 8 files).

Evaluated by: mr-cal-bot

No scores available.

Issue body

When CRAFT_USE_EXTERNAL_FETCH_SERVICE is set, instrument the spread execution to proxy the traffic from the runners through a fetch-service session. This means copying the certificate file over, configuring the proxy for apt, snapd, etc. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1181 by tigarmo was merged (commit ca7ec04c), adding CRAFT_USE_EXTERNAL_FETCH_SERVICE support to 'craft test' so spread execution proxies runner traffic (apt/snapd) through a fetch-service session. All CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged via canonical/craft-application#1181 (ca7ec04c), adding external fetch-service session support to test execution so runner traffic uses the session proxy when configured.
qwen/qwen3.6-35b-a3b
Impact: 35
Quick Win: 13
Complexity: 45
Confidence: 75
Actionability: 70
needs review Adds support for fetch-service sessions in the test command by configuring spread execution to proxy traffic through a fetch-service session when CRAFT_USE_EXTERNAL_FETCH_SERVICE_FOR_TEST is set.

Update history

Date Change
closed
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1199 feat: support CRAFT_TEST_FETCH_SERVICE_SESSIONS craft-application merged Merged PR #1199 (commit e2f9f3ba) adds CRAFT_TEST_FETCH_SERVICE_SESSIONS so tests use a fetch-service session URL instead of HTTP_PROXY; shipped in craft-application 7.5.0 with docs, unit and spread tests.
86%
#837 feat: "support" existing fetch-service sessions craft-application merged Merged in craft-application#837 as d03d8b43, adding external fetch-service and proxy-certificate environment support as groundwork; the PR explicitly delivered only partial packing support.
75%
#1201 test: add helpers to manipulate fetch-service sessions craft-application merged Merged into main as c80ce0e1: PR #1201 added test helpers for creating and tearing down fetch-service sessions, replacing repetitive curl calls and file manipulation.
75%
#762 tests(spread): add a test for the fetch-service rockcraft merged Merged PR #762 in commit f4cff41c, adding 51 lines of spread-test coverage for the fetch service across two files.
71%