style: format shell scripts with shfmt
Metadata
Current evaluation
Merged PR applying shfmt formatting to repository shell scripts ahead of Starbase sync; +182/-182 across 4 files.
Resolution: closed resolved
Reason: PR #1212 was merged after approval with all CI checks passing and no unresolved review comments. It applied shfmt formatting to craft_application/misc/instance_bashrc, spread/.extension, and spread test extensions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
🤖 This is a preparation PR for the Starbase sync, isolating the mechanical shell script formatting changes.
### Summary
- Applies standard `shfmt` formatting to repository shell scripts (`craft_application/misc/instance_bashrc`, `spread/.extension`, and spread test extensions).
- Pre-emptively satisfies the `shfmt` linter/formatter introduced in [canonical/starbase#565](https://github.com/canonical/starbase/pull/565).
Provenance:
- Starbase PR: [canonical/starbase#565](https://github.com/canonical/starbase/pull/565)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed resolved | Merged PR applying shfmt formatting to repository shell scripts ahead of Starbase sync; +182/-182 across 4 files. | |
| ~deepseek/deepseek-pro-latest |
Impact:
15
Quick Win:
13
Complexity:
10
Confidence:
92
Actionability:
95
|
needs review | Applies shfmt formatting to shell scripts (instance_bashrc, spread/.extension, spread test extensions) ahead of Starbase sync. Approved, CI green, no unresolved comments. | |
| ~deepseek/deepseek-pro-latest |
Impact:
20
Quick Win:
15
Complexity:
10
Confidence:
85
Actionability:
85
|
needs review | Applies shfmt formatting to repo shell scripts (instance_bashrc, spread/.extension, spread test extensions) ahead of Starbase sync; +182/-182 lines, CI green, awaiting review. | |
| ~deepseek/deepseek-pro-latest |
Impact:
25
Quick Win:
17
Complexity:
15
Confidence:
85
Actionability:
80
|
needs review | Applies shfmt formatting to 4 shell scripts (instance_bashrc, spread/.extension, two spread test extensions); mechanical prep for Starbase sync. +182/-182, CI green, awaiting review. | |
| ~deepseek/deepseek-pro-latest |
Impact:
20
Quick Win:
12
Complexity:
25
Confidence:
85
Actionability:
80
|
needs review | Applies shfmt formatting to 4 shell scripts (instance_bashrc, spread/.extension, spread test extensions) as prep for Starbase sync. Mechanical +182/-182 diff, CI green, awaiting review. | |
| ~deepseek/deepseek-pro-latest |
Impact:
15
Quick Win:
11
Complexity:
10
Confidence:
90
Actionability:
80
|
needs review | Applies shfmt formatting to 4 shell scripts (instance_bashrc, spread/.extension, spread test extensions) as prep for Starbase sync. Mechanical +182/-182 diff, CI passing, awaiting review. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/starbase#565
(confidence 90%)
This PR pre-emptively satisfies the shfmt linter/formatter introduced in canonical/starbase#565.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1022 style: reformat shell scripts with shfmt | craft-providers | merged | Merged PR #1022 to mechanically reformat shell scripts in craft-providers using shfmt v3.12.0. Changes are purely whitespace and quoting with no logic modifications. | |
| #565 feat(build): add shfmt tool for shell formatting | starbase | merged | Merged #565 in commit e978069, adding shfmt formatting, a make format-shell target, and a pre-commit hook; this implemented #531. | |
| #531 Add shell formatting tool | starbase | closed | Added shfmt formatting and linting plus a pre-commit hook in merged PR #565 (commit e978069). |