Add shell formatting tool
Metadata
Current evaluation
Added shfmt formatting and linting plus a pre-commit hook in merged PR #565 (commit e978069).
Resolution: closed resolved
Reason: Merged PR canonical/starbase#565 implemented the requested shell formatting workflow in commit e978069. The maintainer explicitly marked the issue completed via #565.
Evaluated by: mr-cal-bot
No scores available.
Issue body
We have a fair amount of shell scripts in our repositories and would benefit from uniform formatting.
[shfmt](https://github.com/mvdan/sh) is a popular choice but it's worth researching alternatives first.
**Tasks**
- Add a `make format-shell` to format shell scripts
- Add a pre-commit hook for similar functionality, such as [pre-commit-shfmt](https://github.com/scop/pre-commit-shfmt)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Added shfmt formatting and linting plus a pre-commit hook in merged PR #565 (commit e978069). | |
| stealth/space-bunny-alpha | — | closed resolved | Added shfmt support, make format-shell, and a pre-commit hook via merged PR #565 (commit e978069). | |
| qwen/qwen3.6-35b-a3b | — | — | Added make format-shell and a pre-commit hook for shell script formatting. Completed and merged via pull request #565. | |
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
17
Staleness:
70
Complexity:
15
Confidence:
90
Support Request:
0
|
close stale | Feature request to add shell script formatting via shfmt with a make target and pre-commit hook. Both tasks were implemented by merged PR #565 (format-shfmt make target and scop/pre-commit-shfmt hook now in the repo), but the issue remains open. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
65
Complexity:
15
Confidence:
90
Support Request:
0
|
needs triage | Request to add shell script formatting via shfmt or similar, including a make target and pre-commit hook. Currently unlabelled, no maintainer comments, and inactive for 75 days. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
45
Complexity:
20
Confidence:
90
Support Request:
0
|
needs triage | Request to add a shell script formatting tool and pre-commit hook. Currently unlabelled, no maintainer comments or activity for 62 days, awaiting triage and implementation. |
Update history
| Date | Change |
|---|---|
| closed |
Related work
-
Likely Fixed By:
canonical/starbase#565
(confidence 100%)
Merged PR adding shfmt support, Makefile formatting integration, and pre-commit handling.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #565 feat(build): add shfmt tool for shell formatting | starbase | merged | Merged #565 in commit e978069, adding shfmt formatting, a make format-shell target, and a pre-commit hook; this implemented #531. | |
| #1022 style: reformat shell scripts with shfmt | craft-providers | merged | Merged PR #1022 to mechanically reformat shell scripts in craft-providers using shfmt v3.12.0. Changes are purely whitespace and quoting with no logic modifications. | |
| #1212 style: format shell scripts with shfmt | craft-application | merged | Merged PR applying shfmt formatting to repository shell scripts ahead of Starbase sync; +182/-182 across 4 files. | |
| #405 style: add pre-commit to auto-formatting | starbase | merged | Merged PR #405 added pre-commit auto-formatting in commit 18e50d3, updating two files and passing all CI checks. | |
| #505 test: make completion test robust to shfmt formatting | craft-cli | merged | Merged PR #505 fixes test_completion_output by formatting the expected fixture with shfmt and normalizing generated output, preventing byte-for-byte comparison failures after repo tooling reformatting. |