style: reformat shell scripts with shfmt
Metadata
Current evaluation
Merged PR #1022 to mechanically reformat shell scripts in craft-providers using shfmt v3.12.0. Changes are purely whitespace and quoting with no logic modifications.
Resolution: closed resolved
Reason: The pull request was merged, applying mechanical shfmt formatting to sources.sh, ci-shell.sh, and freeze-requirements.sh without altering any logic.
Evaluated by: mr-cal-bot
No scores available.
Issue body
🤖 [BEEP BOOP, A BOT WROTE THIS COMMENT - mimo-v2.6-flash-free, opencode]
Mechanically reformat the repository's shell scripts with `shfmt`
(v3.12.0, the same binary the `format-shfmt`/`lint-shfmt` targets install):
- `craft_providers/util/sources.sh`
- `tools/ci-shell.sh`
- `tools/freeze-requirements.sh`
No logic changes; the diff is whitespace/quoting only. `shfmt -d` is clean
over the full discovered file set.
Provenance: `shfmt` tooling comes from Starbase
(canonical/starbase#565, https://github.com/canonical/starbase/pull/565).
Split out of the Starbase merge so the formatting diff can be reviewed and
reverted independently of the merge.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR #1022 to mechanically reformat shell scripts in craft-providers using shfmt v3.12.0. Changes are purely whitespace and quoting with no logic modifications. | |
| ~deepseek/deepseek-pro-latest |
Impact:
20
Quick Win:
9
Complexity:
15
Confidence:
70
Actionability:
55
|
needs review | Mechanically reformats 3 shell scripts with shfmt; whitespace/quoting only. Approved by 1 reviewer, no unresolved comments; CI has 2 failing checks (lint/files, OSV-scanner). | |
| ~deepseek/deepseek-pro-latest |
Impact:
20
Quick Win:
8
Complexity:
10
Confidence:
60
Actionability:
45
|
keep open | Reformats three shell scripts with shfmt v3.12.0; whitespace/quoting only. CI has failing lint/files and OSV-scanner checks, with slow tests pending. | |
| ~deepseek/deepseek-pro-latest |
Impact:
15
Quick Win:
6
Complexity:
15
Confidence:
60
Actionability:
45
|
needs review | Reformats three shell scripts with shfmt v3.12.0; whitespace/quoting only. CI has failing lint/files and OSV-scanner checks, with slow tests pending. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1212 style: format shell scripts with shfmt | craft-application | merged | Merged PR applying shfmt formatting to repository shell scripts ahead of Starbase sync; +182/-182 across 4 files. | |
| #531 Add shell formatting tool | starbase | closed | Added shfmt formatting and linting plus a pre-commit hook in merged PR #565 (commit e978069). | |
| #565 feat(build): add shfmt tool for shell formatting | starbase | merged | Merged #565 in commit e978069, adding shfmt formatting, a make format-shell target, and a pre-commit hook; this implemented #531. |