← Back to issue list

style(black): update black to v24

View original Github issue

Metadata

Project
craft-application
Number
#185
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged style PR #185 (commit c4fa7570) bumping Black to v24: adjusted pyproject.toml config and reformatted 4 files (net +8/-12).

Resolution: closed resolved

Reason: The PR was merged into main as commit c4fa7570 ("style(black): update black to v24 (#185)") after approval by two reviewers, updating the Black configuration in pyproject.toml plus the automatic reformatting of four files. It followed the dependency bumps in #169 and #176 that brought Black v24 into the lint group.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- All automatic except for the change to pyproject.toml

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged style PR #185 (commit c4fa7570) bumping Black to v24: adjusted pyproject.toml config and reformatted 4 files (net +8/-12).
stealth/space-bunny-alpha — closed resolved Merged Black v24 upgrade in #185 (commit c4fa7570), updating pyproject.toml and reformatting four files.
qwen/qwen3.6-35b-a3b — — Merged update to Black v24, modifying pyproject.toml and auto-formatting four files. Approved by two reviewers, passed CI, and maintained 99.28% test coverage.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#176 (confidence 70%)

    Commit 9815d93a bumped the black dependency to v24, which this PR then adapted the codebase to.

  • Likely Fixed By: canonical/craft-application#169 (confidence 65%)

    Commit 621a1051 updated the lint/black dependency to v24, the prerequisite for this formatting PR.

  • Superseded By: canonical/craft-application#212 (confidence 55%)

    Commit aae9d000 replaced the Black formatter with ruff format, later followed by #363 (e583ec8e) removing Black entirely, making this Black-specific work moot.

Related issues

Issue Project State Summary Similarity
#1491 style(autoformat): update black to 2024 charmcraft merged Merged PR #1491 in commit 15273c6b, updating Black to the 2024 style and reformatting five Python files.
78%
#5122 build(deps): update dependency black to v24.10.0 (main) snapcraft merged Renovate dependency bump PR merged: black upgraded from 24.8.0 to 24.10.0 in spread-test uv-hello pyproject.toml, landing as commit e13bb0574 after approval by two reviewers.
77%
#3722 static: black update to 22 syntax snapcraft merged Merged PR #3722 (branch 'black', commit 3afcb2ade, merge commit 24ce5d5b0) into main, reformatting 55 files for Black 22 syntax; a prerequisite cleanup for the later switch from black to the ruff formatter.
77%
#638 style: update to black 2024 craft-parts merged Merged PR #638 as commit 423ad779, applying Black 2024 formatting to resolve formatting-related CI failures exposed by #627.
76%
#2599 static: update to newer black snapcraft merged Merged #2599, applying formatting from a newer Black release across 15 files in commit 05913cd56.
75%
#111 chore(deps): update dependency lint/black to v24 craft-archives merged Renovate PR merged as commit 90769cb, bumping lint/black from ==23.9.1 to ==24.4.2 in pyproject.toml (1 line). Later black was dropped in favor of ruff formatter (#119/#363).
74%
#283 build(deps): update dependency black to v24.8.0 craft-cli merged Renovate PR merged as commit 08adabb, bumping the black dev pin from ==24.4.2 to ==24.8.0 (1 file, +1/-1). Later superseded when black was dropped from the project in #305/#363.
74%
#291 build(deps): update dependency black to v24.10.0 craft-cli merged Renovate PR merged as commit faa05d0, bumping the black dev dependency from 24.8.0 to 24.10.0 (one-line pin change). Later superseded by removal of black in #305/#363.
73%
#2180 code: use black as the standard style snapcraft merged Merged PR #2180 made Black the standard Python style, reformatting 567 files; merge commit 96da199ac.
72%
#4684 build(deps-dev): bump black from 24.1.1 to 24.3.0 snapcraft closed Closed unmerged as redundant after black 24.3.0 was applied by #4695 (merge commit c056a64fe).
72%