← Back to issue list

static: black update to 22 syntax

View original Github issue

Metadata

Project
snapcraft
Number
#3722
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3722 (branch 'black', commit 3afcb2ade, merge commit 24ce5d5b0) into main, reformatting 55 files for Black 22 syntax; a prerequisite cleanup for the later switch from black to the ruff formatter.

Resolution: closed resolved

Reason: PR #3722 was approved and merged into main as merge commit 24ce5d5b0 ('Merge pull request #3722 from snapcore/black'), applying Black 22 formatting to 55 files (+313/-141). Black itself was later dropped in favour of the ruff formatter (chore: replace black with ruff formatter / #363).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3722 (branch 'black', commit 3afcb2ade, merge commit 24ce5d5b0) into main, reformatting 55 files for Black 22 syntax; a prerequisite cleanup for the later switch from black to the ruff formatter.
stealth/space-bunny-alpha — closed resolved Merged Black 22 syntax reformatting across 55 files into main via PR #3722 (merge commit 24ce5d5b0).
stealth/space-bunny-alpha — closed resolved Merged PR #3722 (3afcb2a), updating 55 files to Black v22 syntax. Review was approved and no CI checks were reported failing; coverage fell only 0.08%.
qwen/qwen3.6-35b-a3b — — Merged update to Black formatter v22 syntax across 55 files. Approved by reviewer, passed CI, and integrated into main despite a minor 0.08% coverage decrease.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main, updating the Black code formatter to v22 syntax. The change passed all checks and introduced a minor 0.07% coverage decrease per Codecov.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3650 (confidence 80%)

    Earlier lint PR 'lint: apply autoformat-black to source files' that preceded this Black 22 reformat.

  • Superseded By: canonical/snapcraft#363 (confidence 70%)

    Later PR removed black entirely in favour of the ruff formatter, making the Black 22 formatting pass historical.

  • Related To: snapcraft#4029 (confidence 55%)

    Follow-up 'lint: reformat for black 23.1.0' showing this as the start of a series of formatter-update passes.

Related issues

Issue Project State Summary Similarity
#2599 static: update to newer black snapcraft merged Merged #2599, applying formatting from a newer Black release across 15 files in commit 05913cd56.
84%
#2603 black: minor format changes from updated black snapcraft merged Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing.
80%
#212 style: replace black formatter with ruff format starbase merged Merged PR #212 as commit aae9d00, replacing Black with Ruff format across seven files (+26/-10).
79%
#638 style: update to black 2024 craft-parts merged Merged PR #638 as commit 423ad779, applying Black 2024 formatting to resolve formatting-related CI failures exposed by #627.
78%
#185 style(black): update black to v24 craft-application merged Merged style PR #185 (commit c4fa7570) bumping Black to v24: adjusted pyproject.toml config and reformatted 4 files (net +8/-12).
77%
#119 style: replace black with ruff formatter craft-archives merged Merged PR #119 replaced Black with the Ruff formatter across 14 files (+42/-21), completing the style migration.
77%
#1084 build(style): switch from black to ruff craft-parts merged Merged #1084 as commit b28a1dfc, replacing Black with Ruff and autoformatting 32 files; all CI checks passed.
76%
#4029 lint: reformat for black 23.1.0 snapcraft merged Merged PR #4029 (commit 51c24948) reformatting 66 files for Black 23.1.0. The only failing check was a setuptools>=66 unit-test breakage, fixed separately by #4031 pinning setuptools<66.
75%
#739 style: switch from black to ruff craft-providers merged Merged #739 as commit 2b9c894, replacing Black with Ruff formatting across 23 files in preparation for Starbase adoption.
75%
#3853 lint: lint legacy code with black snapcraft merged Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting.
75%