← Back to issue list

refactor!: remove get_build_plan from project

View original Github issue

Metadata

Project
craft-application
Number
#209
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Successfully merged following two reviewer approvals and passing CI checks. The change refactors the codebase by removing the get_build_plan function, directly resolving issue #208.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Fixes #208

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Successfully merged following two reviewer approvals and passing CI checks. The change refactors the codebase by removing the get_build_plan function, directly resolving issue #208.
qwen3.6-35b-a3b-mtp-q6 Merged a breaking refactor removing the get_build_plan method from the project module, resolving issue #208. The maintainer-approved change passed tox checks and was integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#273 feat(project): keep the full build plan for later use craft-application merged Merged to retain the full build plan in the project for remote build execution. Approved by two reviewers with no unresolved comments. The commit modifies one file with a four-line addition and three-line removal.
73%
#4384 refactor(remote-build): reorganize functions snapcraft merged Merged a two-commit refactor reorganizing remote-build functions to prepare for issue #4322. Approved by two reviewers, passed CI checks, and modified two files with a net reduction of 40 lines.
71%
#208 Remove Project's get-build-plan craft-application closed The get_build_plan method was removed from the Project class and superseded by the BuildPlanner. The issue was closed to complete the code cleanup.
71%
#715 refactor: use craft-platform for the build plans rockcraft merged Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files.
70%