← Back to issue list

refactor: use craft-platform for the build plans

View original Github issue

Metadata

Project
rockcraft
Number
#715
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files.

Suggested action:

No scores available.

Issue body

The semantics are the same; the goal is to have a single source of build plans that is used both by Rockcraft and by whatever other code (e.g. remote builds) might need it. Fixes #698 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files.
qwen3.6-35b-a3b-mtp-q6 Merged, consolidating build plans into a single source via craft-platform for Rockcraft and remote builds. Closes #698.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor to centralize build plans using craft-platform for Rockcraft and remote builds, resolving #698. Semantics remain unchanged while establishing a single source of truth for build configurations.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1894 refactor: use craft-platforms for build plans charmcraft merged Merged a refactor replacing custom build plan logic with craft-platforms for platforms charms. Approved by two reviewers, the change modifies two files with a net reduction of eight lines, streamlining platform handling.
85%
#395 refactor: merge feature/craft-application rockcraft merged Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI.
80%
#5111 feat: use `craft-platforms` for build plans snapcraft merged Merged the change to replace existing build plan logic with the craft-platforms library. Approved by two reviewers, the update modifies six files with a net reduction of 17 lines, streamlining platform detection and build configuration.
79%
#354 refactor: use craft-application for "pack" rockcraft merged Merged a refactor routing rockcraft pack to the new craft-application-based runner, resolving issue #316. The update spans 24 files with 935 additions and 40 deletions, received two approvals, and passed CI checks.
77%
#5205 refactor: use craft-platforms utilities snapcraft merged Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files.
76%
#73 refactor: make rockcraft-pack follow new call conventions craft-actions merged Merged after approvals and CI. Refactored rockcraft-pack to adopt new conventions: actions in dedicated directories, tests co-located, shared logic in common/. Updated 17 files.
74%
#974 refactor: consolidate base-specific knowledge rockcraft open Refactors Rockcraft to consolidate base-specific knowledge (support, pebble, plugins) into a single 'bases' module. Open 346 days with no activity, 2 unresolved review comments, no assigned reviewer, and a failing lint check.
74%
#61 refactor: make shareable components abstract craft-actions merged Merged after three approvals and passing CI checks. Refactored Rockcraft's pack action into abstract, shareable common modules to support future Node-based Craft Actions, modifying 13 files with a net code reduction.
73%
#521 refactor: port code to latest craft-app update rockcraft merged Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines).
73%
#4682 refactor(app): use more code from craft-app snapcraft merged Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines.
72%