refactor: use craft-platform for the build plans
Metadata
Current evaluation
Merged PR #715 (516d29e5) replaced Rockcraft’s custom build-plan generation with craft-platform, creating one shared source for Rockcraft and remote builds; fixes #698.
Resolution: closed resolved
Reason: PR #715 was approved and merged as commit 516d29e5. It implements the planned craft-platform refactor and explicitly fixes issue #698.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The semantics are the same; the goal is to have a single source of build plans that is used both by Rockcraft and by whatever other code (e.g. remote builds) might need it.
Fixes #698
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #715 (516d29e5) replaced Rockcraft’s custom build-plan generation with craft-platform, creating one shared source for Rockcraft and remote builds; fixes #698. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #715 (commit 516d29e5) replaced Rockcraft’s bespoke build-plan logic with craft-platform, providing a shared source for Rockcraft and remote builds and fixing #698. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged, consolidating build plans into a single source via craft-platform for Rockcraft and remote builds. Closes #698. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/rockcraft#698
(confidence 100%)
PR #715 states “Fixes #698” and closed the issue through the merged refactor.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #698 Use craft-platforms for build plans | rockcraft | closed | Merged PR #715 (516d29e5) replaced Rockcraft's custom build-plan generation with craft-platforms, resolving #698 and aligning plans with downstream consumers. | |
| #1876 Use craft-platforms for build plans | charmcraft | closed | Closed as done: charmcraft PR #1894 (commit f1755e8f) switched build plan generation to craft-platforms via craft-application's BuildPlanService; rockcraft did the same in #715. | |
| #1894 refactor: use craft-platforms for build plans | charmcraft | merged | Merged PR #1894 (commit f1755e8f, +25/-33) replaced Charmcraft's custom build-plan generation for `platforms` charms with craft-platforms, routing exhaustive build plans through craft-application's BuildPlanService. | |
| #639 Move the build planner logic into craft-platforms | rockcraft | closed | Build planner logic extracted to craft-platforms in merged PR canonical/craft-platforms#25 (commit d9ff004); rockcraft later simplified in commit 5f898b32. Maintainer mr-cal confirmed completion. | |
| #567 refactor: use default BuildPlanner | rockcraft | merged | Merged in canonical/rockcraft#567 as commit 5f898b32, adopting craft-application’s default BuildPlanner after compatibility changes. | |
| #662 [PROTOTYPE] refactor: use craft-platforms | rockcraft | closed | Prototype PR #662 was closed unmerged in August 2024; the production build-planner migration later landed via rockcraft#715 at commit 516d29e5. | |
| #15 Implement a rock build planner | craft-platforms | closed | Rock build planning was implemented and merged in canonical/craft-platforms#25 via commit d9ff004. | |
| #5015 Use craft-platforms for build plans | snapcraft | closed | Snapcraft adopted craft-platforms build plans in merged PR #5111 (commit 7969ee8d5), replacing its custom planning logic. | |
| #391 Use craft-platforms for build plans | craft-application | closed | Build planning and filtering moved to craft-platforms in merged PR #25 (d9ff004); craft-application adopted the planner through merged PR #666 (621d1a32). | |
| #5205 refactor: use craft-platforms utilities | snapcraft | merged | Merged PR #5205 as commit 3aacad74b, replacing local architecture helpers with craft-platforms utilities and closing #4993 (CRAFT-3278). |