← Back to issue list

feat: implement adoptable project variables

View original Github issue

Metadata

Project
craft-application
Number
#217
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #217 as bd3ac7ed; later reverted by 1e33d057 and reintroduced through stacked PR #231 (a7bb9839).

Resolution: closed superseded

Reason: PR #217 was merged as commit bd3ac7ed, then reverted in 1e33d057. The feature was subsequently reintroduced through merged stacked PR #231 as a7bb9839.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Project variables are defined in the application metadata and correspond to fields in the project model that can be set using `craftctl`. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Merged in #217 as bd3ac7ed; later reverted by 1e33d057 and reintroduced through stacked PR #231 (a7bb9839).
stealth/space-bunny-alpha — closed superseded Adoptable project-variable support was merged as PR #217 (bd3ac7ed), later reintroduced through the stacked PR #231 (a7bb9839) after the original was reverted.
stealth/space-bunny-alpha — closed resolved Merged in #217 as bd3ac7ed, adding metadata-backed project variables settable via craftctl and adoption tests. The feature was later reverted in 1e33d057.
qwen/qwen3.6-35b-a3b — — Merged implementation of adoptable project variables, enabling metadata fields to be set via craftctl. Approved by two reviewers, passed CI, and includes integration tests. Changes span 17 files with 216 additions and 24 deletions.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-application#231 (confidence 98%)

    Superseding stacked PR merged after the original implementation was reverted.

  • Caused By: craft-application#231 (confidence 95%)

    Merged as commit a7bb9839 and reintroduced the adoptable project-variable support.

Related issues

Issue Project State Summary Similarity
#233 fix: revert adopt-info feature craft-application merged Merged PR #233 as commit 1e33d057, reverting the adopt-info/adoptable-project-variables feature across 17 files.
71%
#101 feat: do variable expansion when loading project craft-application merged Merged PR #101 added variable expansion when loading projects, landing as commit 4c3162b6.
71%
#872 feat: support nested project variables craft-application merged Merged PR #872 via commit 1554c9e2, adding nested project-variable support; all CI checks passed.
70%