← Back to issue list

fix: revert adopt-info feature

View original Github issue

Metadata

Project
craft-application
Number
#233
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #233 as commit 1e33d057, reverting the adopt-info/adoptable-project-variables feature across 17 files.

Resolution: closed resolved

Reason: PR #233 was approved and merged, with the revert recorded in commit 1e33d057. It removed adopt-info support originally added by #217 and reintroduced by #231.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #233 as commit 1e33d057, reverting the adopt-info/adoptable-project-variables feature across 17 files.
stealth/space-bunny-alpha — closed resolved Merged PR #233 in commit 1e33d057, reverting the adopt-info/adoptable project-variable feature added across #217, #227, and #231.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-application#233 to revert the adopt-info feature, removing 233 lines; the revert is recorded in commit 1e33d057.
qwen/qwen3.6-35b-a3b — — Merged a maintainer pull request reverting the adopt-info feature. Approved by two reviewers and passing CI, the change removed 233 lines across 17 files to undo the previous implementation.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#217 feat: implement adoptable project variables craft-application merged Merged in #217 as bd3ac7ed; later reverted by 1e33d057 and reintroduced through stacked PR #231 (a7bb9839).
71%