← Back to issue list

feat!: remove optional project commands

View original Github issue

Metadata

Project
craft-application
Number
#238
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged changes removing optional project commands to enforce explicit project requirements. Approved by two reviewers and passing CI. Reverts #213 while retaining relevant tests.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Design discussion on this said it was better to remove the options in commands that needed this and enforce a command either needing or not needing a project. This essentially reverts #213 , but leaves the extra tests that are still relevant.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes removing optional project commands to enforce explicit project requirements. Approved by two reviewers and passing CI. Reverts #213 while retaining relevant tests.
qwen3.6-35b-a3b-mtp-q6 Merged a breaking change removing optional project commands to enforce explicit project requirements. The update reverts PR #213 while retaining relevant tests, streamlining the command interface based on design discussions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4628 feat: allow for overriding project asset handling snapcraft merged Merged. Enables overriding project asset handling by consolidating executable settings and adding tests for hook interactions. Approved by two reviewers, passed CI checks, and maintained test coverage.
73%
#64 fix: remove compulsory need for project on service configuration craft-application merged Merged fix removing the compulsory project requirement from service configuration, enabling non-lifecycle commands. Approved by two reviewers, passed CI, and merged into main as a workaround for issue #63.
72%
#153 fix: un-deprecate project attribute craft-application merged Merged a fix un-deprecating the project attribute. Approved by two reviewers with passing CI checks and maintained test coverage. The change modified two files, removing 47 lines and adding 3.
72%
#229 fix: make project directory loading less strict. craft-application merged Merged a change to relax project directory loading validation. Commands like init can now accept non-existent directories, only failing if an existing one is incompatible. Approved by three reviewers, passed CI, and modified two files.
71%