feat!: remove optional project commands
Metadata
Current evaluation
Merged in craft-application#238 via a0a3ed47, removing optional/optimistic project loading introduced by #213 while retaining relevant tests.
Resolution: closed resolved
Reason: PR #238 was approved and merged as commit a0a3ed47. It reversed #213's optimistic project-loading behavior, requiring commands to explicitly need or not need a project.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Design discussion on this said it was better to remove the options in commands that needed this and enforce a command either needing or not needing a project.
This essentially reverts #213 , but leaves the extra tests that are still relevant.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-application#238 via a0a3ed47, removing optional/optimistic project loading introduced by #213 while retaining relevant tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged breaking change removing optional project-loading commands, effectively reverting canonical/craft-application#213 while retaining still-relevant tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes removing optional project commands to enforce explicit project requirements. Approved by two reviewers and passing CI. Reverts #213 while retaining relevant tests. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-application#213
(confidence 100%)
Introduced the optimistic optional project-loading behavior that #238 reverted while preserving relevant tests.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #213 feat: add optimistic project loading | craft-application | merged | Merged in #213 via commit c877412e, adding optimistic loading so commands with always_load_project="try" can continue when project loading fails. | |
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| #340 feat: add `needs_project` property | craft-application | merged | Merged craft-application PR #340 (commit 309aa73b), adding argument-aware needs_project handling and refactoring lifecycle commands; it fixed canonical/snapcraft#4769. | |
| #1572 refactor: remove unused extension command implementations | charmcraft | merged | Merged PR #1572 removed Charmcraft’s unused extension command implementations and moved their tests to craft-application; remote-build test fixes were handled separately in #1573. |