refactor: remove unused extension command implementations
Metadata
Current evaluation
Merged PR #1572 removed Charmcraft’s unused extension command implementations and moved their tests to craft-application; remote-build test fixes were handled separately in #1573.
Resolution: closed resolved
Reason: PR #1572 was approved and merged, completing the removal of unused extension command implementations and migration of their tests to craft-application.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Moves the tests to the craft-application implementations too.
Remote build tests are fixed in #1573
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1572 removed Charmcraft’s unused extension command implementations and moved their tests to craft-application; remote-build test fixes were handled separately in #1573. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1572 removed unused extension command implementations and moved their tests to craft-application. Remote-build smoke-test fixes landed separately in PR #1573. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor removing unused extension command implementations and moving tests to craft-application. Remote build tests were resolved separately in PR #1573. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1573
(confidence 100%)
Merged follow-up that fixed the remote-build smoke tests referenced in PR #1572.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged PR #1520 in commit 97fa9229, removing 248 lines of obsolete init command code after the craft-application transition. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs. | |
| #1546 feat: remote build command | charmcraft | merged | Merged PR #1546 as df5e9c4f, adding Charmcraft 3's remote-build command; bundle builds were addressed separately by merged PR #1550 (c73fd609). | |
| #1663 refactor: remove unused fetch-lib command | charmcraft | merged | PR #1663 (commit b3d35e6d) merged, deleting the unused pre-craft-application fetch-lib implementation; the public fetch-lib command was kept and #1665 added fetch-libs for charmcraft.yaml-declared libraries. | |
| #238 feat!: remove optional project commands | craft-application | merged | Merged in craft-application#238 via a0a3ed47, removing optional/optimistic project loading introduced by #213 while retaining relevant tests. | |
| #1364 feat(craft-application): miscellaneous commands | charmcraft | merged | Merged #1364 into main, adding craft-application analyse and extension-related commands. A charmcraft init failure reported on the PR was addressed by follow-up PR #1367. |