refactor: remove unused extension command implementations
Metadata
Current evaluation
Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files.
Suggested action: —
No scores available.
Issue body
Moves the tests to the craft-application implementations too.
Remote build tests are fixed in #1573
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor removing unused extension command implementations and moving tests to craft-application. Remote build tests were resolved separately in PR #1573. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactor removing unused extension command implementations and relocating tests to craft-application. Remote build test fixes were addressed in PR #1573. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. | |
| #1419 refactor: remove non craft-application analyze command | charmcraft | merged | Merged refactoring that removes a superfluous non-craft-application version of the analyze command. Approved by three reviewers with zero unresolved comments. Modified seven files, deleting 339 lines and adding 135. | |
| #4682 refactor(app): use more code from craft-app | snapcraft | merged | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| #3781 extensions: refactor | snapcraft | merged | Merged refactoring of extensions to prevent future cyclic import issues. Approved by reviewer, passed CI, and integrated into main. Reduced code by 163 lines across six files with a minor coverage decrease. | |
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed. | |
| #1417 fix: expand-extensions overview | charmcraft | merged | Merged into main. This pull request fixes the expand-extensions overview for the craft-application based command, mirroring PR #1416. Approved by two reviewers with passing CI checks, the change modifies one file with five additions and two deletions. | |
| #5205 refactor: use craft-platforms utilities | snapcraft | merged | Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). | |
| #4586 refactor: move core22 commands for versioned implementation | snapcraft | merged | Merged a pure rename refactor moving core22 commands for versioned implementation. Approved by four reviewers and passed CI. Full spread tests were enabled per request; failures attributed to external craft-application updates. |