← Back to issue list

lifecycle: move PartsLifecycle to LifecycleService

View original Github issue

Metadata

Project
craft-application
Number
#27
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #27 in commit d166936f, moving PartsLifecycle into LifecycleService to centralize command business logic.

Resolution: closed resolved

Reason: PR #27 was merged into main as commit d166936f, relocating PartsLifecycle to LifecycleService as approved.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- The business logic for various commands will live in service classes, so the business logic for lifecycle should live there too.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #27 in commit d166936f, moving PartsLifecycle into LifecycleService to centralize command business logic.
stealth/space-bunny-alpha — closed resolved Merged PR #27 (d166936f) relocated PartsLifecycle to LifecycleService, centralizing command business logic; coverage remained at 100%.
stealth/space-bunny-alpha — closed resolved Merged PR #27, relocating PartsLifecycle to LifecycleService to centralize command business logic; commit d166936f preserved 100% coverage.
stealth/space-bunny-alpha — closed resolved Merged PR #27 in commit d166936f, moving PartsLifecycle into LifecycleService to centralize command business logic while retaining 100% test coverage.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI checks. Relocated PartsLifecycle to LifecycleService to centralize business logic. Updated 9 files with 100% test coverage and no overall coverage impact.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#25 parts: add PartsLifecycle support craft-application merged Merged PR #25 as commit 3fa6c712, adding PartsLifecycle support for CRAFT-1752 with tests and 100% diff coverage.
71%
#1626 lifecycle: split into its own package snapcraft merged Merged PR #1626 as commit 5aab678b8, splitting the lifecycle module into its own package to separate concerns and improve navigability.
70%