feat(platforms): support --build-for to select platform
Metadata
Current evaluation
PR #272 (merge commit e99ee656) added --build-for platform selection with build-on/build-for plan filtering and host_arch support in _filter_plan; approved and merged by maintainer syu-w, fixing #254.
Resolution: closed resolved
Reason: Merged into main as commit e99ee656 with 2 approvals; the PR implements --build-for/build-on filtering in BuildPlanService and closes issue #254 ('Implement --build-for in addition to --platform'), which had otherwise gone stale.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Filter plans based on `platform`, `build-on`, and `build-for`.
Use `platform` if it matched `build-for`
There is an API change that `_filter_plan` now need `host_arch` parameter, which can be used in remote builds.
Fixes: #254
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #272 (merge commit e99ee656) added --build-for platform selection with build-on/build-for plan filtering and host_arch support in _filter_plan; approved and merged by maintainer syu-w, fixing #254. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #272 as e99ee656, adding --build-for platform selection, build-on/build-for plan filtering, and host_arch support for remote builds; fixes #254. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to add --build-for flag for platform selection and update _filter_plan API with host_arch parameter for remote builds. Approved by two reviewers, passed CI, and resolves issue #254. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-application#254
(confidence 98%)
PR body declares 'Fixes: #254'; the feature request issue was closed by this merge.
-
Caused By:
craft-application#228
(confidence 55%)
Earlier commit b7f85363 'feat!(app): forward build-on and build-for' set up forwarding that this PR completes with plan filtering.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #254 Implement --build-for in addition to --platform | craft-application | closed | Implemented --build-for platform selection in merged PR canonical/craft-application#272 (commit e99ee656). | |
| #86 feat(project): add support to platforms in build plan | craft-application | merged | Merged #86 added platform-name filtering for build plans, fixing #83; landed as commit e494797a. | |
| #362 feat: support platforms for the build plans | rockcraft | merged | Merged PR #362, adding platform support to build plans; the change is recorded in commit 9cc5af95. | |
| #4992 remote build: filter build plan with `--build-for`, drop `--platform` | snapcraft | closed | Closed by mr-cal as implemented in merged PR #5216 (commit 359a364cb, CRAFT-3277, snapcraft 8.7): `remote-build` now filters the build plan with --build-for, and --platform was dropped pending Launchpad's full platforms support. | |
| #5216 feat(remotebuild)!: filter build-plan with --build-for, drop --platform | snapcraft | merged | Merged as commit 359a364cb (CRAFT-3277): `remote-build` now filters the build plan with `--build-for`, `--platform` was removed, and Launchpad errors are caught instead of surfacing as internal errors. Ships in snapcraft 8.7; closes #4992. | |
| #83 Support "platforms" for the build plans | craft-application | closed | Platform support for build plans was merged in craft-application#86 (commit e494797a), adding platform-name selection/filtering and closing #83. |