feat(project): add support to platforms in build plan
Metadata
Current evaluation
Implemented generic platform name filtering for build plans, resolving issue #83. Merged after reviewer approval and passing CI checks with 100% diff coverage.
Suggested action: —
No scores available.
Issue body
Allow the user to specify a platform name to filter build plans.
Fixes #83
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Notes:
- Exact requirements in #83 not listed. This PR implements a generic way to select a build by platform name.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Implemented generic platform name filtering for build plans, resolving issue #83. Merged after reviewer approval and passing CI checks with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged implementation of generic platform filtering for build plans, resolving issue #83. Approved following successful rockcraft validation, with changes achieving 100% test coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #362 feat: support platforms for the build plans | rockcraft | merged | Merged feature adding platform support for build plans. Approved by two reviewers, the change modifies eight files (+39/-32 lines) and integrates the functionality. | |
| #686 fix(ProjectService): better handling for invalid platforms | craft-application | merged | Merged fix improving ProjectService invalid platform handling. Approved by two reviewers, passes CI, and updates the changelog. Incorporates targeted commits addressing review feedback from PR #683 across five files. | |
| #52 feat: add support for the "platforms" primitive | rockcraft | merged | Implemented multi-arch support via the platforms primitive, resolving issue #49. Merged after reviewer approval, passing CI checks, and conflict resolution. | |
| #867 feat(project): update Platform schema | rockcraft | merged | Merged, updating the Platform schema and superseding #862. Approved by two reviewers with 96 additions and 19 deletions across 16 files. The merge proceeded despite a failing OSV-scanner CI check. | |
| #5216 feat(remotebuild)!: filter build-plan with --build-for, drop --platform | snapcraft | merged | Merged after review and passing CI. Introduces --build-for to filter build plans, removes --platform due to Launchpad API limitations, and improves error handling. Resolves #4992. | |
| #272 feat(platforms): support --build-for to select platform | craft-application | merged | Merged to add --build-for flag for platform selection and update _filter_plan API with host_arch parameter for remote builds. Approved by two reviewers, passed CI, and resolves issue #254. | |
| #5111 feat: use `craft-platforms` for build plans | snapcraft | merged | Merged the change to replace existing build plan logic with the craft-platforms library. Approved by two reviewers, the update modifies six files with a net reduction of 17 lines, streamlining platform detection and build configuration. | |
| #365 feat: accept build-for: [all] in platforms | craft-application | merged | Merged via rebase after approval and passing CI. Enables build-for: [all] in platform definitions, restricting other platforms when used. Resolves #360. | |
| #601 feat: use platform name in build instance name | craft-application | merged | Merged. Changes build instance naming to use platform names instead of architectures, preventing shared environments. Approved by two reviewers, the +40/-10 line update across four files fixes #600 and unblocks dependent work. | |
| #4992 remote build: filter build plan with `--build-for`, drop `--platform` | snapcraft | closed | Resolved via PR #5216. Implemented --build-for filtering for remote build plans. The --platform flag was dropped pending full Launchpad support for the platforms key. |