← Back to issue list

feat(project): add support to platforms in build plan

View original Github issue

Metadata

Project
craft-application
Number
#86
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged #86 added platform-name filtering for build plans, fixing #83; landed as commit e494797a.

Resolution: closed resolved

Reason: PR #86 was merged after two approvals and maintainer sign-off, landing as commit e494797a. It implements platform-name selection for build plans and explicitly fixes #83.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Allow the user to specify a platform name to filter build plans. Fixes #83 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- Notes: - Exact requirements in #83 not listed. This PR implements a generic way to select a build by platform name.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #86 added platform-name filtering for build plans, fixing #83; landed as commit e494797a.
stealth/space-bunny-alpha — closed resolved PR #86 by cmatsuoka merged (commit e494797a), adding platform-name selection/filtering for build plans in craft-application and closing the long-stale issue #83.
stealth/space-bunny-alpha — closed resolved Merged PR #86 added platform-name filtering for build plans, fixing #83; landed as commit e494797a after approval and maintainer sign-off.
qwen/qwen3.6-35b-a3b — — Implemented generic platform name filtering for build plans, resolving issue #83. Merged after reviewer approval and passing CI checks with 100% diff coverage.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#362 feat: support platforms for the build plans rockcraft merged Merged PR #362, adding platform support to build plans; the change is recorded in commit 9cc5af95.
82%
#83 Support "platforms" for the build plans craft-application closed Platform support for build plans was merged in craft-application#86 (commit e494797a), adding platform-name selection/filtering and closing #83.
80%
#686 fix(ProjectService): better handling for invalid platforms craft-application merged Merged PR #686 as commit 651f7573, improving ProjectService handling of invalid platforms and updating the changelog; changes originated from review feedback on #683.
74%
#272 feat(platforms): support --build-for to select platform craft-application merged PR #272 (merge commit e99ee656) added --build-for platform selection with build-on/build-for plan filtering and host_arch support in _filter_plan; approved and merged by maintainer syu-w, fixing #254.
73%
#21 feat: make build plans for snaps with platforms craft-platforms merged Merged PR #21 in commit 5278aa0, adding platforms-based Snap build-plan generation and fixing #5.
73%
#5216 feat(remotebuild)!: filter build-plan with --build-for, drop --platform snapcraft merged Merged as commit 359a364cb (CRAFT-3277): `remote-build` now filters the build plan with `--build-for`, `--platform` was removed, and Launchpad errors are caught instead of surfacing as internal errors. Ships in snapcraft 8.7; closes #4992.
71%
#867 feat(project): update Platform schema rockcraft merged Platform schema update merged (+96/-19 across 16 files), superseding #862; resolving commit 1c9790c0.
70%