← Back to issue list

feat: support platforms for the build plans

View original Github issue

Metadata

Project
rockcraft
Number
#362
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged feature adding platform support for build plans. Approved by two reviewers, the change modifies eight files (+39/-32 lines) and integrates the functionality.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged feature adding platform support for build plans. Approved by two reviewers, the change modifies eight files (+39/-32 lines) and integrates the functionality.
qwen3.6-35b-a3b-mtp-q6 Merged maintainer tigarmo's feature enabling platform selection for build plans. The implementation was accepted and integrated into the codebase without additional review.
qwen3.6-35b-a3b-mtp-q6 Merged changes adding platform support to build plans. The maintainer signed the CLA and the code was integrated without additional review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5111 feat: use `craft-platforms` for build plans snapcraft merged Merged the change to replace existing build plan logic with the craft-platforms library. Approved by two reviewers, the update modifies six files with a net reduction of 17 lines, streamlining platform detection and build configuration.
80%
#598 feat: allow for multi-base builds craft-application merged Merged to enable multi-base builds by allowing bases in the platforms entry. Approved by three reviewers, passed CI, and resolves issue #569. Modified four files with 46 additions and 28 deletions.
77%
#86 feat(project): add support to platforms in build plan craft-application merged Implemented generic platform name filtering for build plans, resolving issue #83. Merged after reviewer approval and passing CI checks with 100% diff coverage.
76%
#5368 feat: add a BuildPlan service snapcraft merged Merged addition of a BuildPlan service and create_launchpad_build_plan() method to support remote builds. The change adds 847 lines and removes 125 across five files, updates unit tests, and received two reviewer approvals.
75%
#601 feat: use platform name in build instance name craft-application merged Merged. Changes build instance naming to use platform names instead of architectures, preventing shared environments. Approved by two reviewers, the +40/-10 line update across four files fixes #600 and unblocks dependent work.
73%
#326 feat: add Platform model and default BuildPlanner craft-application merged Merged after two approvals. Adds a Platform model and default BuildPlanner. The maintainer coordinated timing with related remote-build PRs to bundle fixes in a craft-application hotfix.
73%
#1894 refactor: use craft-platforms for build plans charmcraft merged Merged a refactor replacing custom build plan logic with craft-platforms for platforms charms. Approved by two reviewers, the change modifies two files with a net reduction of eight lines, streamlining platform handling.
73%
#273 feat(project): keep the full build plan for later use craft-application merged Merged to retain the full build plan in the project for remote build execution. Approved by two reviewers with no unresolved comments. The commit modifies one file with a four-line addition and three-line removal.
72%
#343 feat: allow commands to accept multiple platforms craft-application merged Successfully merged following approval from two reviewers and passing CI checks. The feature enables commands to accept multiple platforms, updating two files with 42 additions and one deletion.
71%
#666 feat!(services): build plan service craft-application merged Merged the build plan service implementation, resolving CRAFT-4159. Approved by two reviewers and passing CI, the change spans 42 files with 1851 additions and 786 deletions.
71%