← Back to issue list

feat: support platforms for the build plans

View original Github issue

Metadata

Project
rockcraft
Number
#362
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #362, adding platform support to build plans; the change is recorded in commit 9cc5af95.

Resolution: closed resolved

Reason: PR #362 was approved by two reviewers and merged. Commit 9cc5af95 records the resulting platform support for build plans.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #362, adding platform support to build plans; the change is recorded in commit 9cc5af95.
stealth/space-bunny-alpha — closed resolved Merged platform support for build plans in rockcraft#362, updating plan handling across eight files.
stealth/space-bunny-alpha — closed resolved Platform support for build plans was merged after approval by two reviewers. No PR number or merge commit was included in the supplied record.
stealth/space-bunny-alpha — closed resolved Merged tigarmo's “feat: support platforms for the build plans” after two approvals; eight files changed (+39/-32).
qwen/qwen3.6-35b-a3b — — Merged feature adding platform support for build plans. Approved by two reviewers, the change modifies eight files (+39/-32 lines) and integrates the functionality.
qwen3.6-35b-a3b-mtp-q6 — — Merged maintainer tigarmo's feature enabling platform selection for build plans. The implementation was accepted and integrated into the codebase without additional review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#86 feat(project): add support to platforms in build plan craft-application merged Merged #86 added platform-name filtering for build plans, fixing #83; landed as commit e494797a.
82%
#83 Support "platforms" for the build plans craft-application closed Platform support for build plans was merged in craft-application#86 (commit e494797a), adding platform-name selection/filtering and closing #83.
80%
#21 feat: make build plans for snaps with platforms craft-platforms merged Merged PR #21 in commit 5278aa0, adding platforms-based Snap build-plan generation and fixing #5.
79%
#5111 feat: use `craft-platforms` for build plans snapcraft merged Merged in #5111 via commit 7969ee8d5, replacing Snapcraft’s custom build-plan logic with craft-platforms utilities.
74%
#326 feat: add Platform model and default BuildPlanner craft-application merged Merged PR #326 as commit 4833c0e9, adding the Platform model and default BuildPlanner; the feature shipped in craft-application 3.0.0.
74%
#698 Use craft-platforms for build plans rockcraft closed Merged PR #715 (516d29e5) replaced Rockcraft's custom build-plan generation with craft-platforms, resolving #698 and aligning plans with downstream consumers.
73%
#598 feat: allow for multi-base builds craft-application merged Merged as d81c39a7; allowed bases in platform entries so applications can implement multi-base build plans, fixing #569 (CRAFT-3719).
73%
#81 feat: multi-base support for charm build plans craft-platforms merged Merged PR #81 as commit 519b705, adding multi-base charm build-plan support and fixing #73, with stricter shorthand validation and CraftPlatformsError.
73%
#1894 refactor: use craft-platforms for build plans charmcraft merged Merged PR #1894 (commit f1755e8f, +25/-33) replaced Charmcraft's custom build-plan generation for `platforms` charms with craft-platforms, routing exhaustive build plans through craft-application's BuildPlanService.
71%
#272 feat(platforms): support --build-for to select platform craft-application merged PR #272 (merge commit e99ee656) added --build-for platform selection with build-on/build-for plan filtering and host_arch support in _filter_plan; approved and merged by maintainer syu-w, fixing #254.
71%