← Back to issue list

fix: apply yaml transforms before grammar

View original Github issue

Metadata

Project
craft-application
Number
#316
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged to hotfix/2.6 after reviewers redirected it from hotfix/2.5 to align with other changes. The fix ensures extra_yaml_transforms execute before grammar parsing. Approved and shipped.

Suggested action: —

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- `extra_yaml_transforms` should be applied before grammar because an application may add advanced grammar. I'm targeting `hotfix/2.5` so this can be released as craft-application `2.5.1` and rolled out to snapcraft `8.2.1`. See snapcraft integration here: https://github.com/canonical/snapcraft/pull/4753 LP#2061603 (CRAFT-2817)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged to hotfix/2.6 after reviewers redirected it from hotfix/2.5 to align with other changes. The fix ensures extra_yaml_transforms execute before grammar parsing. Approved and shipped.
qwen3.6-35b-a3b-mtp-q6 — — Merged to hotfix/2.6 after maintainers changed the target branch to group related updates. The fix ensures extra_yaml_transforms apply before grammar, supporting snapcraft integration and enabling craft-application 2.6.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#319 fix: apply yaml transforms before grammar craft-application merged Merged a fix to apply extra_yaml_transforms before grammar processing. Backports #316 to hotfix/2.6, ensuring advanced grammar additions work correctly. Approved by two reviewers and passed CI.
92%
#334 fix: apply yaml transforms first craft-application merged Merged fix ensuring _extra_yaml_transforms execute before project variable evaluation. Resolves snapcraft#4771 by allowing extensions that inject project variables to function correctly. Approved by two reviewers and passed CI checks.
70%