fix: apply yaml transforms before grammar
Metadata
Current evaluation
Merged a fix to apply extra_yaml_transforms before grammar processing. Backports #316 to hotfix/2.6, ensuring advanced grammar additions work correctly. Approved by two reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Same as #316 but targeting `hotfix/2.6`. The other PR got automatically closed and could not be re-opened after I deleted the `hotfix/2.5` branch.
`extra_yaml_transforms` should be applied before grammar because an application may add advanced grammar.
LP#2061603
(CRAFT-2817)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix to apply extra_yaml_transforms before grammar processing. Backports #316 to hotfix/2.6, ensuring advanced grammar additions work correctly. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into hotfix/2.6. Applied extra_yaml_transforms before grammar processing to accommodate applications adding advanced grammar. Backport of #316, resolves LP#2061603 and CRAFT-2817. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #316 fix: apply yaml transforms before grammar | craft-application | closed | Merged to hotfix/2.6 after reviewers redirected it from hotfix/2.5 to align with other changes. The fix ensures extra_yaml_transforms execute before grammar parsing. Approved and shipped. | |
| #328 fix: allow a mix of strings and dicts for grammar | craft-application | merged | Merged a fix allowing mixed strings and dicts in grammar parsing, resolving issue #4764. Approved by two reviewers, the change updates three files with 33 additions and 4 deletions. | |
| #334 fix: apply yaml transforms first | craft-application | merged | Merged fix ensuring _extra_yaml_transforms execute before project variable evaluation. Resolves snapcraft#4771 by allowing extensions that inject project variables to function correctly. Approved by two reviewers and passed CI checks. | |
| #330 fix: do not process non-grammar keywords | craft-application | merged | Merged a fix preventing the grammar processor from incorrectly handling non-grammar keywords, resolving snapcraft.yaml parsing errors. The change skips grammar processing for non-grammar fields, approved by reviewers and passing CI. |