tests(spread): regression test for grammar and non-grammar lists
Metadata
Current evaluation
Merged PR #4768 (c76e62671) added spread regressions for mixed grammar/non-grammar lists and fixed #4764 through craft-application 2.6.2 parser fixes.
Resolution: closed resolved
Reason: PR #4768 was merged as commit c76e62671, adding regression coverage for mixed grammar and standard list entries and closing #4764. Craft-application 2.6.2 supplied the parser fixes from canonical/craft-application#328 and the follow-up #330; the fix shipped in Snapcraft 8.2.2.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Fixes https://github.com/canonical/snapcraft/issues/4764
~~Needs a craft-application 2.6.1 release to pull in https://github.com/canonical/craft-application/pull/328~~
Needs a craft-application 2.6.2 release to pull in https://github.com/canonical/craft-application/pull/330
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4768 (c76e62671) added spread regressions for mixed grammar/non-grammar lists and fixed #4764 through craft-application 2.6.2 parser fixes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4768 as c76e6267, adding spread regressions for mixed grammar and non-grammar lists and closing #4764 after craft-application 2.6.2 delivered the parser fix. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4768, adding spread regressions for mixed grammar/non-grammar lists. It closed #4764 and required craft-application 2.6.2 to include parser fix craft-application#330. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged Snapcraft #4768 (c76e6267), adding regression tests for mixed grammar and non-grammar lists; craft-application 2.6.2 supplies the underlying fix. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged Snapcraft PR #4768 added regression coverage for mixed grammar and non-grammar lists, fixing #4764 using craft-application PRs #328 and #330. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged regression tests for grammar and non-grammar lists. Requires craft-application 2.6.2. Author merged despite unrelated spread test failures, confirming they do not impact the changes. Approved by reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged despite unrelated spread test failures. Adds regression tests for grammar and non-grammar lists, resolving issue #4764 via craft-application 2.6.2. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#4764
(confidence 100%)
Merged PR #4768 closes this regression and adds spread coverage.
-
Likely Fixed By:
canonical/craft-application#330
(confidence 98%)
Follow-up fix prevented grammar processing of non-grammar part keywords and was included in craft-application 2.6.2.
-
Likely Fixed By:
canonical/craft-application#328
(confidence 95%)
Parser fix allowed grammar lists to mix strings and dictionaries.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #16 tests: add spread support | rockcraft | merged | Merged PR #16 added Spread support for CRAFT-865 via commit 3aeba2b3 (merge commit 5bf2680a). | |
| #4924 tests: add spread tests for validation-sets | snapcraft | merged | Merged PR #4924 added spread coverage for edit-validation-sets and list-validation-sets, closing #4918; merge commit 157d0a182. | |
| #4764 Regression: Advanced grammar cannot be combined with other data | snapcraft | closed | Fixed by merged snapcraft#4768 (c76e62671), adding regression coverage for mixed grammar and standard list entries; parsing was fixed in craft-application 2.6.2. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. | |
| #4716 test(grammar): new grammar support | snapcraft | closed | PR #4716 (unit tests for new grammar support) was approved but closed unmerged; maintainer @mr-cal closed it because craft-application#296 was merged/released and equivalent Snapcraft tests landed in merged #4768 (c76e626). | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files. | |
| #1381 fix: fix most spread tests on craft-application | charmcraft | merged | Merged #1381 fixed most CRAFT-2239 craft-application Spread failures; follow-up #1386 fixed the remaining different-dir and full-lifecycle tests. |