tests(spread): regression test for grammar and non-grammar lists
Metadata
Current evaluation
Merged regression tests for grammar and non-grammar lists. Requires craft-application 2.6.2. Author merged despite unrelated spread test failures, confirming they do not impact the changes. Approved by reviewers.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Fixes https://github.com/canonical/snapcraft/issues/4764
~~Needs a craft-application 2.6.1 release to pull in https://github.com/canonical/craft-application/pull/328~~
Needs a craft-application 2.6.2 release to pull in https://github.com/canonical/craft-application/pull/330
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged regression tests for grammar and non-grammar lists. Requires craft-application 2.6.2. Author merged despite unrelated spread test failures, confirming they do not impact the changes. Approved by reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged despite unrelated spread test failures. Adds regression tests for grammar and non-grammar lists, resolving issue #4764 via craft-application 2.6.2. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged regression tests for grammar and non-grammar lists. Depends on craft-application 2.6.2. Proceeded with merge despite unrelated spread test failures in package-repositories. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #16 tests: add spread support | rockcraft | merged | Merged after approval and passing CI, adding spread support to tests per CRAFT-865. | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127. | |
| #4924 tests: add spread tests for validation-sets | snapcraft | merged | Merged changes adding spread tests for edit-validation-sets and list-validation-sets. Approved by two reviewers with passing CI, resolving issue #4918. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #1386 fix: final spread test fixes for craft-application | charmcraft | merged | Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch. | |
| #1266 tests(spread): requirements dependencies | charmcraft | merged | Merged following approval by two reviewers. Introduces regression tests for requirements file and dependency combinations, resolving issue #1179. The change modifies five files, adding 149 lines and removing one. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback. | |
| #1381 fix: fix most spread tests on craft-application | charmcraft | merged | Merged updates fixing most spread tests for craft-application. Two smoketests remain broken. Approved despite minor linting and unit test failures. Resolves CRAFT-2239. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. |