application: ServiceFactory and main Application class
Metadata
Current evaluation
Merged following two reviewer approvals. The maintainer delayed integration to address missing unit test coverage, ensuring all CI checks passed before adding the ServiceFactory and main Application class implementations.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
CRAFT-1755
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following two reviewer approvals. The maintainer delayed integration to address missing unit test coverage, ensuring all CI checks passed before adding the ServiceFactory and main Application class implementations. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after adding missing unit tests to satisfy coverage checks. Introduces ServiceFactory and the main Application class for CRAFT-1755. Diff coverage remained at 96.23%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #75 refactor: pass the service factory to the services | craft-application | merged | Merged into main. Refactored service initialization to pass the ServiceFactory instance, enabling inter-service communication. Approved by two reviewers, passed CI, and achieved 100% diff coverage across 12 modified files. | |
| #40 services: allow the service factory to be created before the project. | craft-application | merged | Merged into main. Enables creating the service factory before the project. Approved by two reviewers, modified nine files with 65 additions and 13 deletions, and increased test coverage by 0.01%. |