refactor: pass the service factory to the services
Metadata
Current evaluation
Merged into main. Refactored service initialization to pass the ServiceFactory instance, enabling inter-service communication. Approved by two reviewers, passed CI, and achieved 100% diff coverage across 12 modified files.
Suggested action: —
No scores available.
Issue body
In order to allow services knowing each other, pass the ServiceFactory instance to the individual Services on initialization.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Refactored service initialization to pass the ServiceFactory instance, enabling inter-service communication. Approved by two reviewers, passed CI, and achieved 100% diff coverage across 12 modified files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Refactors service initialization to pass the ServiceFactory instance to individual services, enabling inter-service communication. Achieved 100% test coverage upon merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #40 services: allow the service factory to be created before the project. | craft-application | merged | Merged into main. Enables creating the service factory before the project. Approved by two reviewers, modified nine files with 65 additions and 13 deletions, and increased test coverage by 0.01%. | |
| #35 application: ServiceFactory and main Application class | craft-application | merged | Merged following two reviewer approvals. The maintainer delayed integration to address missing unit test coverage, ensuring all CI checks passed before adding the ServiceFactory and main Application class implementations. | |
| #1001 docs: Reference document for the Service Factory | craft-application | merged | Merged documentation update adding a reference guide for the Service Factory. Approved by two reviewers, passed all CI checks, and changed 24 lines across two files. Minor discussion on method signature rendering was resolved. | |
| #654 refactor(ServiceFactory): de-dataclass the ServiceFactory | craft-application | merged | Merged a refactor removing the dataclass decorator from ServiceFactory, as it was only retained for historical registration methods. Approved by two reviewers, passed CI, and required PR #653. Modified 2 files. | |
| #77 refactor: use consolidated helper service | debcraft | merged | Merged a refactor consolidating helper functions from individual services into a unified helper service, organized by lifecycle phases. Approved by two reviewers, passed all CI checks, and resolves issue #73 across 22 files. |