← Back to issue list

feat: allow strict/permissive fetch-service sessions

View original Github issue

Metadata

Project
craft-application
Number
#490
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #490 as d327e604, requiring --use-fetch-service to select strict or permissive sessions and fixing craft-application#487.

Resolution: closed resolved

Reason: PR #490 was approved and merged as commit d327e604. It made --use-fetch-service require either strict or permissive, resolving issue #487.

Evaluated by: mr-cal-bot

No scores available.

Issue body

'--use-fetch-service' now takes a mandatory argument defining the type of session to use: "strict" or "permissive". Fixes #487 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #490 as d327e604, requiring --use-fetch-service to select strict or permissive sessions and fixing craft-application#487.
stealth/space-bunny-alpha — closed resolved Merged as d327e604, requiring --use-fetch-service to specify a strict or permissive session and resolving craft-application#487.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI checks, adding mandatory strict or permissive session arguments to the --use-fetch-service flag. Resolves issue #487.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#487 (confidence 100%)

    The issue requested command-line selection of strict fetch-service sessions and was explicitly fixed by PR #490.

Related issues

Issue Project State Summary Similarity
#487 Allow strict fetch-service sessions on the command-line craft-application closed Added mandatory strict or permissive modes to --use-fetch-service in merged PR #490 (commit d327e604).
79%
#837 feat: "support" existing fetch-service sessions craft-application merged Merged in craft-application#837 as d03d8b43, adding external fetch-service and proxy-certificate environment support as groundwork; the PR explicitly delivered only partial packing support.
79%
#1199 feat: support CRAFT_TEST_FETCH_SERVICE_SESSIONS craft-application merged Merged PR #1199 (commit e2f9f3ba) adds CRAFT_TEST_FETCH_SERVICE_SESSIONS so tests use a fetch-service session URL instead of HTTP_PROXY; shipped in craft-application 7.5.0 with docs, unit and spread tests.
74%
#272 feat: add fetch-service version to session metadata fetch-service merged Merged PR #272 added a generator field with the fetch-service version to session metadata, resolving fetch-service#258; merged as commit a0e826f.
71%