← Back to issue list

feat: use platform name in build instance name

View original Github issue

Metadata

Project
craft-application
Number
#601
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged. Changes build instance naming to use platform names instead of architectures, preventing shared environments. Approved by two reviewers, the +40/-10 line update across four files fixes #600 and unblocks dependent work.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Changes the build instance name to use the platform rather than the `build-on` and `build-for` architectures. This prevents the same build environment being used for multiple platforms. See https://github.com/canonical/charmcraft/pull/2069 for examples. Fixes #600 Unblocks https://github.com/canonical/charmcraft/pull/2069 (CRAFT-3859)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Changes build instance naming to use platform names instead of architectures, preventing shared environments. Approved by two reviewers, the +40/-10 line update across four files fixes #600 and unblocks dependent work.
qwen3.6-35b-a3b-mtp-q6 Merged. Changes build instance naming to use platform names instead of architectures, preventing shared environments and fixing #600. Required craft-providers and craft-application updates, resolved via rebases.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#598 feat: allow for multi-base builds craft-application merged Merged to enable multi-base builds by allowing bases in the platforms entry. Approved by three reviewers, passed CI, and resolves issue #569. Modified four files with 46 additions and 28 deletions.
76%
#365 feat: accept build-for: [all] in platforms craft-application merged Merged via rebase after approval and passing CI. Enables build-for: [all] in platform definitions, restricting other platforms when used. Resolves #360.
74%
#947 feat!(platforms): prevent use of '/' in platform names craft-application merged Prevents use of '/' in platform names, resolving issue #941 and CRAFT-4876. Merged after approval by two reviewers and passing all CI checks across four modified files.
74%
#442 fix(platform): automatically vectorise architectures craft-application merged Merged fix allowing the Platform model to accept string or list values for build-on and build-for architectures, resolving issue #1874. Approved by two reviewers, passed CI, and modified two files.
73%
#362 feat: support platforms for the build plans rockcraft merged Merged feature adding platform support for build plans. Approved by two reviewers, the change modifies eight files (+39/-32 lines) and integrates the functionality.
73%
#483 feat: support "--platform" for "clean" craft-application merged Added --platform flag to the clean command for targeted instance cleanup. Merged after three approvals and passing CI, resolving issue #425. Changes modify three files with 52 additions.
71%
#86 feat(project): add support to platforms in build plan craft-application merged Implemented generic platform name filtering for build plans, resolving issue #83. Merged after reviewer approval and passing CI checks with 100% diff coverage.
71%
#380 feat: use debian arch in platforms rockcraft merged Merged. Updates Rockcraft platforms to use Debian architecture format, drops the build variant concept, and localizes image fetching logic. Approved by two reviewers, passed CI, and resolves issues #370 and #358.
71%
#3820 providers: specify build-on and build-for in instance name snapcraft merged Merged changes to instance naming convention, incorporating build-on and build-for architecture specifications. Approved by reviewers, passed CI with 100% coverage, and enables core22 multi-architecture support.
71%
#2200 feat(templates): change the templates to use platforms notation charmcraft merged Merged update switching templates from bases to platforms notation while temporarily retaining Jammy builds. Approved by two reviewers, resolves #2167, and modifies five files with a net reduction of 48 lines.
70%