feat!(platforms): prevent use of '/' in platform names
Metadata
Current evaluation
Merged PR #947 as commit f7f3b1ff, adding validation that rejects platform names containing "/" and fixing #941 (CRAFT-4876).
Resolution: closed resolved
Reason: PR #947 was approved and merged as commit f7f3b1ff. The merged change adds platform-name validation and explicitly fixes issue #941 (CRAFT-4876).
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Fixes #941 CRAFT-4876
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #947 as commit f7f3b1ff, adding validation that rejects platform names containing "/" and fixing #941 (CRAFT-4876). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-application#947 as commit f7f3b1ff, adding validation to reject platform names containing '/' and fixing #941 (CRAFT-4876). | |
| qwen/qwen3.6-35b-a3b | — | — | Prevents use of '/' in platform names, resolving issue #941 and CRAFT-4876. Merged after approval by two reviewers and passing all CI checks across four modified files. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#941
(confidence 100%)
PR #947 explicitly states that it fixes issue #941 (CRAFT-4876).
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #936 feat!(platform): add reserved platform names | craft-application | merged | Merged PR #936 (commit b534c8a8) adding RESERVED_PLATFORM_NAMES in craft_application/models/platforms.py, blocking '*' and 'any'; fixes #890 (CRAFT-4747). Includes ruff 0.14.0 bump. | |
| #176 feat!(platform): make 'any' and '*' invalid platform names | craft-platforms | merged | Merged #176 as commit 62631bd, rejecting 'any' and '*' as platform names and adding reusable reserved-name handling; fixes #166. | |
| #209 feat: validate platform names | craft-platforms | merged | Merged PR #209 (commit 2a92a08): get_build_plan now validates platform names and a new craft_platforms.validators/platform_types module offers validation helpers. Shipped in craft-platforms 0.11.0. | |
| #84 fix: do not strip base from platform names | craft-platforms | merged | Merged PR #84 via commit 7680af2: shorthand platform names now retain their base, preventing duplicate BuildInfo names required by craft-application. | |
| #941 Platform names should not be allowed to contain `/` characters | craft-application | closed | Platform names containing '/' are now rejected during model validation, preventing packing failures. Resolved by canonical/craft-application#947 in commit f7f3b1ff. | |
| #483 feat: support "--platform" for "clean" | craft-application | merged | Merged PR #483 via commit 07e89deb, adding --platform to clean so one managed instance can be removed, and fixing craft-application#425. | |
| #2590 docs: add platform naming rules | charmcraft | merged | PR #2590 by lengau was approved by two reviewers and merged into main as commit 3313a280, adding craft-application's platform naming rules to docs/reference/platforms.rst (docs-only, +49/-13). | |
| #601 feat: use platform name in build instance name | craft-application | merged | Merged in canonical/craft-application#601 as 5ae7f878: build instance names now use the platform, preventing environment reuse across platforms and fixing #600. |