← Back to issue list

feat!(platforms): prevent use of '/' in platform names

View original Github issue

Metadata

Project
craft-application
Number
#947
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Prevents use of '/' in platform names, resolving issue #941 and CRAFT-4876. Merged after approval by two reviewers and passing all CI checks across four modified files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Fixes #941 CRAFT-4876

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Prevents use of '/' in platform names, resolving issue #941 and CRAFT-4876. Merged after approval by two reviewers and passing all CI checks across four modified files.
qwen3.6-35b-a3b-mtp-q6 Merged a feature preventing forward slashes in platform names, resolving issue #941 and CRAFT-4876. The change passed lint and test checks, updated the changelog, and was approved by a maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#706 fix: improve the handling of platforms errors. craft-application merged Merged fix for platform error handling. Approved by two reviewers with all CI checks passing. Resolves issue #690 and CRAFT-4369/4370. Modifies eight files with 98 additions and 239 deletions.
77%
#428 feat: tell the user which platforms matched when failing craft-application merged Implemented a feature to display matched platforms during failures. Merged after approval by three reviewers, the update modifies three files (+25/-6 lines) and resolves CRAFT-3107.
76%
#1011 feat: strict platform name validation craft-application open Adds strict platform name validation via craft-platforms validator, skipping legacy bases (ubuntu 20.04-24.04). 216/13 lines across 10 files. Pending review, 1 unresolved comment, 4 failing CI jobs (fast tests, min deps, lint).
75%
#495 feat: add craft-platforms compatibility methods craft-application merged Merged after approval by two reviewers and passing CI checks. Added craft-platforms compatibility methods and deprecation warnings. Documentation breakage was later resolved in PR #498.
74%
#601 feat: use platform name in build instance name craft-application merged Merged. Changes build instance naming to use platform names instead of architectures, preventing shared environments. Approved by two reviewers, the +40/-10 line update across four files fixes #600 and unblocks dependent work.
74%
#2590 docs: add platform naming rules charmcraft merged Merged documentation update adding platform naming rules from craft-application. Approved by two reviewers. Integrated despite non-blocking CI test failures and type checker notifications.
73%
#1130 docs: add platform naming rules rockcraft merged Merged documentation update adding platform naming rules from Craft Application. Approved by three reviewers with all CI checks passing. A noted merge conflict was resolved prior to final merge.
73%
#936 feat!(platform): add reserved platform names craft-application merged Merged. Reserves * and any as platform names and establishes a framework for additional reserved names. Approved by three reviewers with all CI checks passing. A proposed character domain restriction was deferred to future work.
73%
#6092 docs(reference): add platform naming rules snapcraft merged Merged documentation update adding platform naming rules. The change also bumps the craft-application minor release to resolve a lint dependency. Approved by two reviewers and passed CI checks before integration.
71%
#2200 feat(templates): change the templates to use platforms notation charmcraft merged Merged update switching templates from bases to platforms notation while temporarily retaining Jammy builds. Approved by two reviewers, resolves #2167, and modifies five files with a net reduction of 48 lines.
70%