fix: do not strip base from platform names
Metadata
Current evaluation
Merged PR #84 via commit 7680af2: shorthand platform names now retain their base, preventing duplicate BuildInfo names required by craft-application.
Resolution: closed resolved
Reason: PR #84 was merged and implemented the fix in commit 7680af2 by preserving the base in shorthand platform names. The change prevents duplicate BuildInfo platform names, while intentionally making shorthand and standard notation non-equivalent.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
-----
Minor followup of #81.
This PR prevents multiple `BuildInfo`s from having the same platform name, which can happen when using the shorthand notation. This is a problem because craft-application expects platform names to be unique in a build plan.
On the other hand, this change means that the shorthand and standard notations are no longer equivalent.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #84 via commit 7680af2: shorthand platform names now retain their base, preventing duplicate BuildInfo names required by craft-application. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged fix preventing duplicate platform names in BuildInfo by preserving the base in shorthand notation, satisfying craft-application's uniqueness requirement. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
canonical/craft-platforms#81
(confidence 98%)
PR #84 is described as a minor follow-up to the merged multi-base support work in #81.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #601 feat: use platform name in build instance name | craft-application | merged | Merged in canonical/craft-application#601 as 5ae7f878: build instance names now use the platform, preventing environment reuse across platforms and fixing #600. | |
| #947 feat!(platforms): prevent use of '/' in platform names | craft-application | merged | Merged PR #947 as commit f7f3b1ff, adding validation that rejects platform names containing "/" and fixing #941 (CRAFT-4876). | |
| #2646 fix(Project): fix shorthand multi-base notation | charmcraft | merged | Merged as 9dbd59a6, updating craft-platforms to fix craft-application 6 multi-base shorthand notation and adding regression coverage; fixes charmcraft#2620. | |
| #598 feat: allow for multi-base builds | craft-application | merged | Merged as d81c39a7; allowed bases in platform entries so applications can implement multi-base build plans, fixing #569 (CRAFT-3719). | |
| #6092 docs(reference): add platform naming rules | snapcraft | merged | Merged platform naming rules into the reference docs and bumped craft-application; the related lint fix was handled in canonical/craft-application#1023 (commit 83c5b7d4e). | |
| #936 feat!(platform): add reserved platform names | craft-application | merged | Merged PR #936 (commit b534c8a8) adding RESERVED_PLATFORM_NAMES in craft_application/models/platforms.py, blocking '*' and 'any'; fixes #890 (CRAFT-4747). Includes ruff 0.14.0 bump. | |
| #5351 fix(remote): error early for invalid platform usage | snapcraft | merged | PR #5351 merged as commit 0c224fc7d, adding an early, friendlier error when --build-for is used with shorthand project platforms instead of failing at Launchpad. Fixes #5270 (CRAFT-4186); restriction later lifted by #5687. | |
| #44 fix: better compatibility for craft-providers | craft-platforms | merged | Merged PR #44 (commit 8b6608e) exported Platforms and PlatformDict and made BaseName properties read-only, resolving issue #43. | |
| #483 feat: support "--platform" for "clean" | craft-application | merged | Merged PR #483 via commit 07e89deb, adding --platform to clean so one managed instance can be removed, and fixing craft-application#425. | |
| #633 fix: improve `platforms.<platform>.build-on` validation | rockcraft | closed | Closed unmerged as redundant: PR canonical/rockcraft#567 had already improved build-on validation by adopting craft-application's default BuildPlanner. |