← Back to issue list

refactor: move the test command to lifecycle

View original Github issue

Metadata

Project
craft-application
Number
#626
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #626 moved testing into the lifecycle after pack and passed packed-artifact state to spread tests.

Resolution: closed resolved

Reason: PR #626 was merged and explicitly states that it fixes #613. Follow-up PR #694 later completed the testing service and command in commit 4910b2d8.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The test command in the next lifecycle step after pack, passing the artifact generated by the pack command to spread tests. This commit contains a shortcut to pass packed artifact information from the managed instance back to the outer instance. This must be stored in a proper location to provide state management for the pack and test steps of the application lifecycle. Fixes #613 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #626 moved testing into the lifecycle after pack and passed packed-artifact state to spread tests.
stealth/space-bunny-alpha — closed resolved Merged lifecycle refactor moved test after pack to pass the packed artifact to spread tests; the PR explicitly states that it fixes #613.
qwen/qwen3.6-35b-a3b — — Merged a refactor moving the test command to the lifecycle step after pack, enabling artifact passing and state management. Fixes #613. The branch was rebased onto main and variable names updated for readability before merging.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#613 (confidence 100%)

    The PR description explicitly identifies #613 as fixed.

  • Related To: craft-application#694 (confidence 95%)

    Merged commit 4910b2d8 added the testing service and opt-in test command.

Related issues

Issue Project State Summary Similarity
#2163 tests: add lifecycle ordering tests snapcraft merged Merged in #2163 via commit efebd07e9, adding lifecycle-ordering tests and refactoring lifecycle tests into a dedicated package; Codecov reported 100% diff coverage.
70%
#766 fix(lifecycle): don't rebuild on test file changes craft-application merged Merged PR canonical/craft-application#766 excluded spread test files from lifecycle outdated checks, preventing test-only changes from repulling local source parts and resolving #756.
70%