← Back to issue list

chore: mark redundant functions as deprecated.

View original Github issue

Metadata

Project
craft-application
Number
#650
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Marks redundant functions as deprecated across 15 files. Open 563 days with no reviews, comments, or CI. Deprecation work appears superseded by subsequent PRs (#660, #768, #1078) and codebase has evolved through multiple major versions.

Suggested action: close stale

Reason: PR is 563 days old with zero activity, reviews, or CI. The deprecation work it targets has been addressed in subsequent merged PRs: #660 marked ServiceFactory.set_kwargs() deprecated, #768 marked Application._set_global_environment deprecated, and #1078 removed deprecated APIs entirely. The codebase has advanced from ~4.x to 7.3.0, making this diff almost certainly unmergeable without a full rebase.

Impact: 20 Quick Win: 14.0 Staleness: 92 Complexity: 30 Confidence: 60

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 20
Quick Win: 14.0
Staleness: 92
Complexity: 30
Confidence: 60
close stale Marks redundant functions as deprecated across 15 files. Open 563 days with no reviews, comments, or CI. Deprecation work appears superseded by subsequent PRs (#660, #768, #1078) and codebase has evolved through multiple major versions.
qwen/qwen3.6-35b-a3b
Staleness: 90
Complexity: 20
Confidence: 85
close stale Marks redundant functions as deprecated across 15 files. PR is inactive for over 1.4 years with no reviews, comments, or CI status.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 20
Confidence: 90
close stale Adds deprecation warnings to redundant functions. The PR has been inactive for 509 days with no comments or CI status, and the codebase has likely diverged significantly since creation.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 15
Confidence: 85
close stale Marks redundant functions as deprecated. Unreviewed pull request with no comments or labels, inactive for 488 days. Awaiting maintainer triage and merge.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-application#660 (confidence 55%)

    Marked ServiceFactory.set_kwargs() as deprecated, overlapping with this PR's goal of marking redundant functions deprecated.

  • Likely Fixed By: craft-application#768 (confidence 55%)

    Marked Application._set_global_environment as deprecated, another targeted deprecation that supersedes this broader PR.

  • Related To: craft-application#1078 (confidence 50%)

    Removed deprecated APIs entirely, indicating the deprecation cycle this PR initiated has already completed.

Related issues

Issue Project State Summary Similarity
#5094 chore: fix deprecation warnings snapcraft merged Merged after approval by two reviewers. The change resolves deprecation warnings from external libraries by updating code across five files, ensuring compatibility and preventing future runtime issues.
73%
#5524 chore: add deprecation warnings for hidden commands snapcraft merged Merged after approval by two reviewers. The update adds uniform deprecation warnings for hidden commands and redirects their reference pages, resolving issue #5428 across 17 files.
72%