← Back to issue list

ci(linters): address warnings

View original Github issue

Metadata

Project
craft-application
Number
#67
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged after addressing linter warnings by removing a pyright-incompatible type annotation on a classmethod parameter. Approved by two reviewers and passed CI checks before integration into main.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after addressing linter warnings by removing a pyright-incompatible type annotation on a classmethod parameter. Approved by two reviewers and passed CI checks before integration into main.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve linter warnings by removing a pyright-incompatible type annotation on a classmethod parameter. The change was accepted despite a minor coverage decrease, successfully addressing static analysis issues.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#177 linting: address pyright issues craft-parts merged Merged following approval and passing CI. Updated type declarations to comply with Pyright 1.1.225 by adding Optional to None arguments and correcting callback type typos across 16 files.
73%
#90 many: address new linter warnings (CRAFT-364) craft-parts merged Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines).
71%