linting: address pyright issues
Metadata
Current evaluation
Merged in craft-parts#177: updated type declarations for Pyright 1.1.225, added Optional for arguments that may be None, and fixed callback annotation typos.
Resolution: closed resolved
Reason: craft-parts#177 received approval and was merged. It brought declarations into compliance with Pyright 1.1.225 by using Optional where appropriate and correcting callback type declarations.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Pyright 1.1.225 correctly enforces use of `Optional` for arguments set to `None`,
so fix declarations to comply. Also fixed type declaration typos in callbacks.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-parts#177: updated type declarations for Pyright 1.1.225, added Optional for arguments that may be None, and fixed callback annotation typos. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #177 as commit 586ca30d, addressing Pyright 1.1.225 errors with Optional annotations for None arguments and callback type corrections across 16 files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval and passing CI. Updated type declarations to comply with Pyright 1.1.225 by adding Optional to None arguments and correcting callback type typos across 16 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated type declarations to comply with Pyright 1.1.225 by correctly applying Optional to None arguments and fixing callback type typos. Linting issues resolved and changes integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #84 packages: address issues raised by pyright 1.1.151 (CRAFT-303) | craft-parts | merged | Merged PR #84 via a24147b5, applying 8aeb3ea8 to fix None-indexing warnings introduced by Pyright 1.1.151. | |
| #1258 Improve typing and linting | craft-parts | closed | Strict Pyright checks and typing fixes were merged in canonical/craft-parts#1294 at bb62329e, addressing suppressions and strict-mode requirements. | |
| #4205 lint: fix for pyright 1.1.312 | snapcraft | merged | Merged #4205 (commit 6b94548db), fixing login argument typing for Pyright 1.1.312 so lint passes. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated. |