← Back to issue list

feat(application): enable build plans

View original Github issue

Metadata

Project
craft-application
Number
#70
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #70 by cmatsuoka merged to main as commit 082e6211, adding the application-defined build plan resolver to enable multi-artefact builds and creating multiple provider instances; closes issue #60.

Resolution: closed resolved

Reason: The PR was merged after two approvals and rebased by the author, landing on main as commit 082e6211 ('feat(application): enable build plans (#70)'). Its stated 'Fixes #60' closed the build-plans support issue, and the resulting services/buildplan.py plus LifecycleService build-plan integration remain in the codebase at the current HEAD.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Enable multi-artefact builds by using the application-defined build plan resolver to create multiple provider instances. Further refactoring may be necessary if applications such as Rockcraft and Charmcraft require additional features. Fixes #60 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> ----- Note * Passing the target architecture in service creation because instantiating the lifecycle manager in the `run` method proved to be problematic in certain situations, this can be refactored later if needed. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #70 by cmatsuoka merged to main as commit 082e6211, adding the application-defined build plan resolver to enable multi-artefact builds and creating multiple provider instances; closes issue #60.
stealth/space-bunny-alpha — closed resolved Merged PR #70 (commit 082e6211) enables multi-artefact builds by using the application-defined build plan resolver to create multiple provider instances; closes issue #60.
stealth/space-bunny-alpha — closed resolved PR #70 merged into main, adding application-defined build-plan resolution so the provider instantiates multiple providers for multi-artefact builds; fixes issue #60.
stealth/space-bunny-alpha — closed resolved Merged #70, adding application-defined build-plan resolution for multi-artefact builds; the author marked it as fixing #60.
qwen/qwen3.6-35b-a3b — — Merged into main, enabling multi-artefact builds via an application-defined build plan resolver. Approved by reviewers, rebased, and CI passed. Resolves #60. Diff coverage at 96.05%.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#60 (confidence 98%)

    The tracking issue 'Support build plans' that this PR declares it fixes.

  • Related To: canonical/craft-application#86 (confidence 55%)

    Follow-up 'feat(project): add support to platforms in build plan' extending the build-plan feature introduced here.

  • Related To: canonical/craft-application#216 (confidence 50%)

    Later 'feat!: use the build plan on LifecycleService' build on the plan/LifecycleService integration added by this PR.

Related issues

Issue Project State Summary Similarity
#60 Support build plans craft-application closed Build-plan support was merged in canonical/craft-application PR #70 via commit 082e6211, enabling multi-artefact builds and provider instances.
76%