← Back to issue list

models/project.py: do not check for base when build-base: devel

View original Github issue

Metadata

Project
craft-application
Number
#761
Type
pull request
State
closed
Author
valentindavid
Labels
—
Created
Updated
Closed

Current evaluation

Rejected unmerged: craft-application retained default devel base/build-base validation; Snapcraft was told to add a gadget-specific _validate_devel_base override.

Resolution: closed not a bug

Reason: Maintainer @lengau declined the change on 2025-06-06, stating the current validation must remain the default for every craft and recommending a Snapcraft-side override for gadget snaps. canonical/snapcraft#5496 was linked as related work, not as a merged resolution.

Evaluated by: mr-cal-bot

No scores available.

Issue body

To be able to build pc snap, we have to set the base to point to the upcoming base, in the present case `core26`, while using `build-base: devel`. This is how we worked on core24 before its release. Verifying the base matches the build base breaks it. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed not a bug Rejected unmerged: craft-application retained default devel base/build-base validation; Snapcraft was told to add a gadget-specific _validate_devel_base override.
stealth/space-bunny-alpha — closed not a bug Closed unmerged; maintainers retained Craft Application's default devel-base validation and directed gadget-snap handling to a Snapcraft-specific override in snapcraft#5496.
stealth/space-bunny-alpha — closed not a bug Rejected unmerged; maintainers retained default base/build-base validation for all crafts and recommended a Snapcraft-specific _validate_devel_base override for gadget snaps.
qwen/qwen3.6-35b-a3b — — Rejected. Maintainers kept the default base validation for all crafts. They advised overriding _validate_devel_base in snapcraft to support the gadget snap use case instead.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5496 (confidence 98%)

    Directly linked by the closing maintainer while discussing handling build-base when the base is set.

Related issues

Issue Project State Summary Similarity
#5388 fix: don't fail when checking the base snapcraft merged Merged PR #5388 in commit 5c43d861c, deferring base-check failures so invalid base definitions reach Snapcraft's user-friendly validation errors (SNAPCRAFT-313).
72%
#5496 models/project.py: do not download base if build base is set snapcraft closed Closed unmerged: skipping base downloads broke core26 with build-base: devel. Native core26 support superseded the change in #5767 (3b9705baf).
71%
#4562 Validity of `base` is not checked when using `--destructive-mode` snapcraft closed Base validation in destructive mode was fixed in Snapcraft 8.1 via craft-application 2.0 and canonical/craft-application PR #263.
70%
#4540 fix(lifecycle): return correct base when using devel for build-base (… snapcraft merged Merged in snapcore/snapcraft#4540 via commit 17666fb25, correcting effective-base selection when build-base is devel; it carried the lifecycle fix from #4523.
70%